[
https://issues.apache.org/jira/browse/DERBY-5068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032467#comment-13032467
]
Dag H. Wanvik edited comment on DERBY-5068 at 5/12/11 3:45 PM:
---------------------------------------------------------------
I think 2a probably strikes the right compromise here: we get a slight
performance improvement in addition to a good code cleanup. +1
One question: Utf8CcsidManager#encode: Is there no need to check for
malformed-input and
unmappable-character errors in the returned CoderResult? The code
presumes it is always OVERFLOW now. Just reading up on the APIs details here
:)
Perhaps we know it can't happen here, a comment might be good for the naive
reader.
was (Author: dagw):
I think 2b probably strikes the right compromise here: we get a slight
performance improvement in addition to a good code cleanup. +1
One question: Utf8CcsidManager#encode: Is there no need to check for
malformed-input and
unmappable-character errors in the returned CoderResult? The code
presumes it is always OVERFLOW now. Just reading up on the APIs details here
:)
Perhaps we know it can't happen here, a comment might be good for the naive
reader.
> Investigate increased CPU usage on client after introduction of UTF-8
> CcsidManager
> ----------------------------------------------------------------------------------
>
> Key: DERBY-5068
> URL: https://issues.apache.org/jira/browse/DERBY-5068
> Project: Derby
> Issue Type: Task
> Affects Versions: 10.7.1.1
> Reporter: Knut Anders Hatlen
> Attachments: d5068-1a.diff, d5068-2a.diff, d5068-2a.stat
>
>
> While looking at the performance graphs for the single-record select test
> during the last year -
> http://home.online.no/~olmsan/derby/perf/select_1y.html - I noticed that
> there was a significant increase (10-20%) in CPU usage per transaction on the
> client early in October 2010. To be precise, the increase seems to have
> happened between revision 1004381 and revision 1004794. In that period, there
> were three commits: two related to DERBY-4757, and one related to DERBY-4825
> (tests only).
> We should try to find out what's causing the increased CPU usage and see if
> there's some way to reduce it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
