[ 
https://issues.apache.org/jira/browse/DERBY-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044884#comment-13044884
 ] 

Mamta A. Satoor commented on DERBY-5164:
----------------------------------------

Hi Knut, thanks for looking at the patch. The reason I wanted these changes in 
trunk and 10.8 is so that we do not loose the information on how upgrade can be 
tested between the point releases to the current codeline of any particular 
release. Having this just in10.7 may not make the technique visible to someone 
who is working with say only trunk.

But giving my tests in the patch a little more thought, I feel that the more 
appropriate place for the tests suggested by derby5164_patch1_diff.txt will be 
in upgradeTests.BasicSetup. The reason for this is that the tests mainly are 
creating triggers and testing the results when they get fired. This kind of 
testing is not unique to any particular Derby release and hence it is better 
for them to go in BasicSetup to make sure that the results are consistent 
between various phases of upgrades for all the releases. We do already know 
that because of the bug DERBY-5121, the results will be incorrect in 10.7.1.1 
and the test is verifying those incorrect reulsts for 10.7.1.1. Based on this, 
I am going to go ahead and commit the changes by putting the tests in 
BasicSetup.java This makes Changes10_8.java to have no tests left in it and 
hence I am deleting Changes10_8.java from svn in trunk.If anyone has any 
feedback, please let me know. Next, I will work on backporting this to 10.8 an
 d 10.7


> Provide a framework to test upgrade between point releases. Currently, the 
> upgrade testing happens between two major versions.
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5164
>                 URL: https://issues.apache.org/jira/browse/DERBY-5164
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.0.2.1, 10.1.3.1, 10.2.2.0, 10.3.3.0, 10.4.2.0, 
> 10.5.3.0, 10.6.2.1, 10.7.1.1
>            Reporter: Mamta A. Satoor
>            Assignee: Mamta A. Satoor
>         Attachments: derby5164_patch1_diff.txt, derby5164_patch1_stat.txt
>
>
> DERBY-5121 found a corruption problem caused by triggers in DERBY release 
> 10.7.1.1 A fix for this has been provided in trunk(10.8) and the 10.7 
> codeline. 10.7.1.1 database upgrade to any one of these 2 codelines will fix 
> the triggers causing the corruption. I was able to write upgrade tests for 
> 10.8 codeline but not for 10.7 codeline. The reason for this can be found in 
> the comment insdie 
> org.apache.derbyTesting.functionTests.tests.upgradeTests.UpgradeRun:baseSuite 
>     * Changes are only added if the old version is older than
>     * then version the changes represent. Thus Changes10_2
>     * is not added if the old database (upgrade from) is already
>     * at 10.2, since Changes10_2 is intended to test upgrade
>     * from an older version to 10.2.
> The last line in the comment "since Changes10_2 is intended to test upgrade 
> from an older version to 10.2." is not really true specifically for 
> DERBY-5121. We want to test upgrade from 10.7.1.1 to next point 
> release/codeline of 10.7.
> Providing this framework should not be too hard. I just wanted to create this 
> jira so we can keep track of the issue.
> More information on this issue can be found at 
> http://mail-archives.apache.org/mod_mbox/db-derby-dev/201103.mbox/%[email protected]%3E

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to