[ 
https://issues.apache.org/jira/browse/DERBY-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045522#comment-13045522
 ] 

Kristian Waagan commented on DERBY-5260:
----------------------------------------

Hi Dag,

I had a look at the changes - they look good to me. I also ran suites.All and 
derbyall without seeing any failures.
+1 to commit.

> Remove unused "replace" argument to backup variant of 
> StorageFactoryService#saveServiceProperties
> -------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-5260
>                 URL: https://issues.apache.org/jira/browse/DERBY-5260
>             Project: Derby
>          Issue Type: Improvement
>          Components: Services
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>            Priority: Minor
>         Attachments: saveServiceProperties-1.diff, 
> saveServiceProperties-1.stat
>
>
> This variant of the method is never called with replace == true, so the code 
> to handle replacement can be removed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to