[
https://issues.apache.org/jira/browse/DERBY-5285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051738#comment-13051738
]
Mike Matrigali commented on DERBY-5285:
---------------------------------------
I'll look at committing this. Did you run any tests on your patch, if so what
were the results?
/mikem
> [patch] avoid npe if tempCongloms is null
> -----------------------------------------
>
> Key: DERBY-5285
> URL: https://issues.apache.org/jira/browse/DERBY-5285
> Project: Derby
> Issue Type: Improvement
> Components: Store
> Affects Versions: 10.8.1.4
> Reporter: Dave Brosius
> Assignee: Mike Matrigali
> Priority: Trivial
> Fix For: 10.8.1.4
>
> Attachments: npe_guard.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> if (tempCongloms != null)
> tempCongloms.remove(new Long(conglomId));
> tempCongloms.put(new Long(conglomId), conglom);
> code guards against tempCongloms being null for the remove, but not for the
> put. so put the put in the if statement.
> Then realized that the remove is superfluous, as the put will overright so
> just removed the remove.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
