[ 
https://issues.apache.org/jira/browse/DERBY-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Knut Anders Hatlen updated DERBY-5288:
--------------------------------------

    Attachment: join-threads.diff

I think the join() call is misplaced. We should call join() right before we try 
to access the output, not when we start the process, as that won't let the test 
start until the process has completed (which is likely why a timeout was needed 
to prevent hangs).

Does the attached patch join-threads.diff preserve the improvements you saw 
with the original patch? This patch calls join() on places where we know the 
process has terminated, and we just need to let the threads that read stdout 
and stderr get enough time to complete before we check the output.

> running multiple suites.All concurrently should be possible
> -----------------------------------------------------------
>
>                 Key: DERBY-5288
>                 URL: https://issues.apache.org/jira/browse/DERBY-5288
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.6.2.3, 10.7.1.4, 10.8.1.4, 10.9.0.0
>            Reporter: Myrna van Lunteren
>            Assignee: Myrna van Lunteren
>         Attachments: DERBY-5288_1.diff, join-threads.diff
>
>
> When attempting to run multiple suites.All runs at the same time, using a 
> different location & jvm & a different value for
> -Dderby.tests.basePort, there are still a few tests that fail regularly.
> The first one is SecureServerTest.
> See also the discussion on this thread: 
> http://osdir.com/ml/derby-dev-db-apache/2011-06/msg00337.html

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to