[ https://issues.apache.org/jira/browse/DERBY-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270399#comment-13270399 ]
Jayaram Subramanian commented on DERBY-4633: -------------------------------------------- Thanks for reviewing Knut. I agree that in terms of performance there is no impact because of DERBY 4582 fix. So i am going ahead and closing the issue. > Cache default calendar in result sets and statements on client driver > --------------------------------------------------------------------- > > Key: DERBY-4633 > URL: https://issues.apache.org/jira/browse/DERBY-4633 > Project: Derby > Issue Type: Improvement > Components: JDBC, Network Client > Affects Versions: 10.6.1.0 > Reporter: Knut Anders Hatlen > Labels: derby_triage10_9 > Attachments: Main.java, Main.java > > > After the changes in DERBY-4582, these methods now allocate a default > calendar object on each invocation (on the client driver), whereas they > didn't before the fix: > ResultSet.getDate(int) > ResultSet.getTime(int) > ResultSet.getTimestamp(int) > PreparedStatement.setDate(int, java.sql.Date) > PreparedStatement.setTime(int, java.sql.Time) > PreparedStatement.setTimestamp(int, java.sql.Timestamp) > CallableStatement.getDate(int) > CallableStatement.getTime(int) > CallableStatement.getTimestamp(int) > The embedded driver prevents excessive allocation of default calendar objects > in these methods by caching an instance in ConnectionChild (the super-class > of EmbedResultSet, EmbedPreparedStatement and EmbedCallableStatement). We > should do something similar on the client driver. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira