[
https://issues.apache.org/jira/browse/DERBY-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411431#comment-13411431
]
Knut Anders Hatlen commented on DERBY-5847:
-------------------------------------------
Committed d5847-6a-obsolete-collection.patch to trunk with revision 1360133.
Committed d5847-7a-sync-on-non-final.patch to trunk with revision 1360134.
Committed d5847-8b-misc.patch to trunk with revision 1360135.
Committed d5847-9b-this-leak.patch to trunk with revision 1360137.
Now the only warnings left to clean up in this file are:
- 345 if/else statements without braces
- 10 for loops without braces
- 1 missing @Override annotation
The latter cannot be fixed without starting to compile the DRDA code with
source level 1.5. That's probably a good idea anyway, since the DRDA code on
trunk isn't supported on earlier Java versions.
> Clean up IDE warnings in DRDAConnThread
> ---------------------------------------
>
> Key: DERBY-5847
> URL: https://issues.apache.org/jira/browse/DERBY-5847
> Project: Derby
> Issue Type: Improvement
> Components: Network Server
> Affects Versions: 10.10.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: d5847-1a-string-equality.patch,
> d5847-2a-unnecessary-return.patch, d5847-3a-static-fields-and-imports.patch,
> d5847-4a-unused-assignment.patch, d5847-5a-performance-warnings.patch,
> d5847-6a-obsolete-collection.patch, d5847-7a-sync-on-non-final.patch,
> d5847-8a-misc.patch, d5847-8b-misc.patch, d5847-9a-this-leak.patch,
> d5847-9b-this-leak.patch
>
>
> When I open DRDAConnThread in NetBeans, I see 49 warnings. Most of them are
> harmless (like static fields accessed via an instance, suggestions about
> using StringBuilder instead of StringBuffer, or using System.arraycopy()
> instead of for loops). Others indicate real problems, like the use of != to
> compare SQL states in writeSQLDIAGGRP().
> We should clean up the warnings so that it's easier to notice new warnings
> about potential problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
