* What's the story with the following bit of code in the permissions manager? Seems problematic. if (credentials.pid != pid || credentials.uid != uid) return Result::granted; // FIXME(tvoss): This should return rejected. * Seems like it's missing a Build-Depends on graphviz for /usr/bin/dot * Should have "Pre-Depends: ${misc:Pre-Depends}" for libubuntu-location-service0 * Has tests and runs them, great! * No important bugs
Also needs lcov and dbus-cpp-dev, which I've added to this bug. I'll look at them next. ** Changed in: location-service (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to location-service in Ubuntu. https://bugs.launchpad.net/bugs/1218896 Title: [MIR] location-service To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dbus-cpp/+bug/1218896/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs