OK. I've had a look at this request. Thanks for the patch to g-s. I had
a brief look at it and I'm not sure why you introduced the lock-request
signal? What happens if the lock fails in manager_lock_request? I think
you leak the GSignals too.
That's only a review from quickly looking at the diff - someone else
should review it properly.
Anyway, I want to give a chance for this to get into Trusty, but I want
to be conservative. So I'll ack this FFe if you can get it in by
Wednesday this week (2014-03-12). We're a month away from final freeze
now and I'm keen to give this as good a run of user testing as possible
before the LTS release.
If not, then I don't want to nack the request—find another RT member
(I'll be away this week) to re-review the state and see if you can try
again.
Please keep an eye on bug reports and feedback and if this doesn't go as
smoothly as we need then we should be prepared to go back to the known
current state and land this solidly next cycle.
** Changed in: unity (Ubuntu)
Status: Incomplete => Triaged
** Changed in: gnome-screensaver (Ubuntu)
Status: In Progress => Triaged
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gnome-screensaver in Ubuntu.
https://bugs.launchpad.net/bugs/1282798
Title:
[FFe] Provide a lock screen and unlock dialogs in Unity
To manage notifications about this bug go to:
https://bugs.launchpad.net/unity/+bug/1282798/+subscriptions
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
