Le mardi 19 juillet 2005 à 16:27 +0200, Rodrigo Moya a écrit : > On Tue, 2005-07-19 at 14:41 +0200, Vincent Untz wrote: > > Hi Rodrigo, > > > > On Tue, July 19, 2005 13:36, Rodrigo Moya said: > > > Hi > > > > > > This patch adds support for SuSE's YAST datetime config tool in the > > > clock applet. > > > > > > Ok to commit? > > > > Thanks for the patch. > > Some comments (I might be totally wrong since I don't have the whole > > code here): > > > ... > > all fixed in the attached patch
Thanks! > > - if (!config_tool) > > + if (config_tool) { > > + bonobo_ui_component_set_prop (popup_component, > > + "/commands/ClockConfig", > > + "hidden", "0", > > + NULL); > > + } else { > > I don't see the point of this. It was not hidden before, was it? > > > while working on this patch, I ran it a few times without it finding > correctly the config tool, and it seems it set it up to hidden at that > time. Then, when running the correct code, I had to add this to put it > back to not hidden. Weird. Anyway, it's okay to do this. > > You also want to change something in config_tool_changed(), I think. > > > like checking if the command entered by the user is correct? Added to > the patch also. Great! Just one last comment: at the end of fill_clock_applet(), cd->config_tool should be set to config_tool, especially if you want to use the hard-coded config tools :-) It's okay to commit after that. Thanks for your work! Vincent -- Les gens heureux ne sont pas pressés. _______________________________________________ desktop-devel-list mailing list desktop-devel-list@gnome.org http://mail.gnome.org/mailman/listinfo/desktop-devel-list