Brian Cameron wrote: > > Robert: > > Thanks for the patch. Could you explain a few things about this patch? > You said you created a bug for this in bugzilla.gnome.org in the gdm > category, but I don't see a bug there. Would you mind adding a bug > and attaching the patch? I already submitted a bug report on opensolaris.org but apparently they don't show up immediately. I've learned from other Sun folks that the bug id # is 6626891. I didn't see any way to attach the patch to the bug report when I submitted it.
> > First, could you explain what specific error(s) you were seeing that > this patch fixes? > The error is that xdmcp doesn't work. > The change to better calculate the address size makes sense to me. > > I notice in misc.c that you are no longer setting hints.ai_family to > AF_INET or AF_INET6. Why is this change needed? > The getaddrinfo() api was failing (I don't have ipv6 configured on the interface). The code made no sense since ai_family is not a bitmask. > Also, I notice you removed NI_NUMERICHOST | NI_NUMERICSERV from > getnameinfo in common/gdm-common.c. I assume this change is needed > so we allow DNS/NIS to be used? Is that correct? > NI_NUMERICHOST | NI_NUMERICSERV forces the result to be returned in numeric form which defeats the whole point of what the function is supposed to return based on its name. If that is really what was intended then inet_ntop() should be called directly. Without those flags the hostname is returned unless it is unavailable in which case the numeric representation is returned. This routine is primarily used to obtain a human-friendly name for logging purposes. > I'll work to get this change upstream. Thanks for the help. > > Thanks, > > Brian > >> I found the problem(s) with gdm and xdmcp. >> >> I uploaded a patch to ftp://ftp.the-nelsons.org/pub. >> >> If you don't want to rebuild SUNWgnome-display-mgr then you can >> download the prebuilt package from there as well. >> >> >> This message posted from opensolaris.org >> _______________________________________________ >> desktop-discuss mailing list >> desktop-discuss at opensolaris.org >
