2008/11/24 dick hoogendijk <dick at nagual.nl>: > > Alexander Skwar wrote: > >>> You probably went a bit too far and replaced more /bin/sh's with >>> /bin/bash's than necessary, but generally okay to commit. >> >> Done. >> >>> But please use our patch naming convention: it should be called >>> qt-01-use-bash.diff >> >> Done as well. > > Does this "new" SFEqt.spec mean that now it does not compile on SXCE? Or
I don't know. It does compile on OpenSolaris (at least somewhat...), which was not the case with the old SFEqt.spec, and that's quite an improvement, if you ask me. :) OTOH: The patch introduced with the new spec just replaces all occrurances of "#!/bin/sh" and "#! /bin/sh" with "#!/bin/bash" or "#! /bin/bash". Because of that, I doubt that it doesn't work on SXCE. If it doesn't why don't you submit a fixed version, which works again on SXCE? :) > does it check its environment. The old one didn't either. So that's a mood point. > If not I oppose to the commit or it shoudl > be under a new name. Or the SXCE one should be under a new name. Or, even better yet, a "combined" spec should be checked in, in case there are problems. Alexander [ Chat => Jabber: alexws77 at jabber80.com | Gmail: a.skwar at gmail.com ] [ Mehr => MSN: alexws77 at live.de | Yahoo!: askwar | ICQ: 350677419 ]
