Looks good to me. Thanks Halton!
Laca
On Thu, 2007-12-20 at 15:22 +0800, Halton Huo wrote:
> Check with SUNWevolution-data-server.spec, there seems wrong logic when
> support level is unsupported.
>
> When supported, we should Requires:SUNWbdb and
> BuildRequires:SUNWevolution-bdb-devel to use solaris bundled bdb.
>
> When unsupported, these two dependencies should not be added.
>
> So the logic is like this.
>
> %define with_bdb %(test %support_level = supported && echo 1 || echo 0)
> %if %with_bdb
> Requires: SUNWbdb
> BuildRequires: SUNWevolution-bdb-devel
> %endif
>
> %if %with_bdb
> %define bdb_option --with-libdb=%{_basedir}
> %else
> %define bdb_option
> %endif
>
>
> The patch for SUNWevolution-data-server.spec is attached.
>
> Laca, could you give your opinion whether it is right or not?
>
> If laca think it is okay, Patrick, could you give a try with the patch?
>
> Thanks,
> Halton.
> On Thu, 2007-12-20 at 18:59 +1300, Laszlo (Laca) Peter wrote:
> > On Wed, 2007-12-19 at 10:42 +0800, Halton Huo wrote:
> > > To fix your e-d-s build problem, you need
> > > have /usr/lib/libdb.so /usr/include/db.h and /usr/include/db_cxx.h
> > > (maybe not required) on you system.
> > >
> > > The easy way is to 'pkgtool build closed/SUNWevolution-bdb-devel.spec'
> >
> > Khmm... note the "closed" bit in the command above.
> > The original idea was that external contributors should be able
> > to build e-d-s with the static db code it comes with and when
> > the bdb devel pkg is there then it builds against the shared
> > lib.
> >
> > Why is this broken now?
> >
> > Laca
> >
> > > Halton.
> > > On Tue, 2007-12-18 at 20:35 +0100, Patrick Ale wrote:
> > > > Hi,
> > > >
> > > > I have two compiles now that rely on SUNWbdb but fail to find the
> > > > libraries.
> > > > The packages in question are SUNWevolution-data-server.spec (spec file
> > > > attached cause it just have been updated and I didn't test the new
> > > > version yet) and the apoc-agent git source.
> > > > When I try to configure the apoc-agent with ./configure
> > > > --with-db-java-libdir=/usr/lib (libdb_java.so is in /usr/lib) I get
> > > > the following error:
> > > >
> > > > configure: error: DB JAVA 4.2 library not found. Check your DBJAVA
> > > > prefix option.
> > > > If it is already installed please use --with-db-java-prefix=DIR or
> > > > --with-db-java-libdir=DIR options to point to the DB JAVA 4.2
> > > > installation prefix or library dir.
> > > >
> > > > Compiling the SUNWevolution-data-server.spec file gives an error libdb
> > > > not found.
> > > >
> > > > doing a strings on the libdb*.so files in /usr/lib shows me it is
> > > > actual version 4.2
> > > > Sleepycat Software: Berkeley DB 4.2.52: (December 3, 2003)
> > > >
> > > >
> > > > --
> > > > Patrick Ale
> > > > Email: patrick.ale at gmail.com
> > > > IRC: WickedWicky
> > > > _______________________________________________
> > > > desktop-discuss mailing list
> > > > desktop-discuss at opensolaris.org
> > >
> > > _______________________________________________
> > > desktop-discuss mailing list
> > > desktop-discuss at opensolaris.org
> >
> > _______________________________________________
> > desktop-discuss mailing list
> > desktop-discuss at opensolaris.org
> _______________________________________________
> desktop-discuss mailing list
> desktop-discuss at opensolaris.org
