Alan Coopersmith wrote:
> I noticed Dave did a bunch of commits last week to "Update OpenGL path"
> which made me curious - it turns out, most of these are bugs that had the
> wrong path anyway.
>
> This code is wrong:
> test -f /usr/lib/xorg/modules/extensions/libglx.so || {
> echo "Missing OpenGL libraries. Stopping."
> echo "As root, run: \"/lib/svc/method/ogl-select start\""
> false
> }
>
> /usr/lib/xorg/modules does not have libraries in, but is the X server
> loadable modules (which is why I closed Dave's bug about not having a
> *.pc file for this as "Not a bug"). You don't link with it any more
> than you link with Firefox plugins.
>
> The entire /usr/lib/xorg directory could be missing on a build machine
> without any consequences - after all, why should you need the Xorg server
> on a headless build machine?
>
> If you want to check that you can link with GL, you should be checking
> /usr/lib/libGL.so, not anything under /usr/lib/xorg. Anything under
> /usr/lib/xorg (or it's previous home of /usr/X11/lib/modules) is a
> private interface, subject to change without warning at the drop of a hat.
>
> While you're in there, you probably want to update the other test:
> test -f /usr/X11/include/GL/glx.h || {
>
> to instead be checking /usr/include/GL/glx.h
>
> And to fix the bad instructions of:
> As root, run: \"/lib/svc/method/ogl-select start\"
> to something more like:
> As root, run: svcadm enable ogl-select
>
Alan,
You're right. The check is not reasonable. I'm going to replace it by
adding "BuildRequires: SUNWxorg-mesa" in the spec files.
I got some build errors with the previous path, then I updated it to get
the build moving forward, I didn't think too much about why this check
is there and what it is use for.
Thanks
Dave
