** Description changed:

+ [Test Case]
+ 1. install the version from -proposed
+ 2. launch a copy of a big file
+ 3. look at the dbus traffic and see that it's not sending the updates signal 
once the copy is finished
+ 
+ [Regression Potential]
+ No regression at stake, the signal can just be still sent if the return FALSE 
fails, which is unlikely.
+ 
  After first triggering launcherentry.updates a added urgency timeout
  never gets dismissed and continuously firing updates from now on.
  
  g_timeout_add_seconds (2, (GSourceFunc)
-                      progress_ui_handler_disable_unity_urgency,
-                      entry);
+                 progress_ui_handler_disable_unity_urgency,
+          entry);
  
  static void
  progress_ui_handler_disable_unity_urgency (UnityLauncherEntry *entry)
  {
-       g_return_if_fail (entry);
+  g_return_if_fail (entry);
  
-       unity_launcher_entry_set_urgent (entry, FALSE);
+  unity_launcher_entry_set_urgent (entry, FALSE);
  }

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1003286

Title:
  dbus unity launcherentry.updates aren't getting dismissed

Status in Files:
  Fix Committed
Status in “nautilus” package in Ubuntu:
  New

Bug description:
  [Test Case]
  1. install the version from -proposed
  2. launch a copy of a big file
  3. look at the dbus traffic and see that it's not sending the updates signal 
once the copy is finished

  [Regression Potential]
  No regression at stake, the signal can just be still sent if the return FALSE 
fails, which is unlikely.

  After first triggering launcherentry.updates a added urgency timeout
  never gets dismissed and continuously firing updates from now on.

  g_timeout_add_seconds (2, (GSourceFunc)
                  progress_ui_handler_disable_unity_urgency,
           entry);

  static void
  progress_ui_handler_disable_unity_urgency (UnityLauncherEntry *entry)
  {
   g_return_if_fail (entry);

   unity_launcher_entry_set_urgent (entry, FALSE);
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/pantheon-files/+bug/1003286/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to