At Thu, 14 Feb 2013 11:36:39 +0100, David Henningsson wrote: > > This chip needs the speaker pin to go to D3 to avoid clicks, > so default_power_filter does not work here. > > This was found on Thinkpad R61i/T61i but I guess it applies to > the entire chip. If not, quirks should be set for at least > PCI SSID 17aa:20ac. > > Thanks to c4pp4 for testing. > > BugLink: https://bugs.launchpad.net/bugs/886975 > Signed-off-by: David Henningsson <david.hennings...@canonical.com>
Thanks, applied now. Just wonder, though, whether rather setting spec->gen.power_down_unused = 1 works. When it's set, the generic parser applies the own power filter, and it doesn't have the EAPD check either (plus it does more aggressive power-down of unused widgets). Or, maybe we just drop the EAPD check, and move it to specific fixup. AFAIK, it was required only for old Gateway laptops. Takashi > --- > sound/pci/hda/patch_conexant.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c > index 7d941ef..941bf6c 100644 > --- a/sound/pci/hda/patch_conexant.c > +++ b/sound/pci/hda/patch_conexant.c > @@ -3350,6 +3350,7 @@ static int patch_conexant_auto(struct hda_codec *codec) > switch (codec->vendor_id) { > case 0x14f15045: > codec->single_adc_amp = 1; > + codec->power_filter = NULL; /* Needs speaker amp to D3 to avoid > click */ > break; > case 0x14f15047: > codec->pin_amp_workaround = 1; > -- > 1.7.9.5 > -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to alsa-driver in Ubuntu. https://bugs.launchpad.net/bugs/886975 Title: [Thinkpad R61i/T61] Lenovo sound chip Conexant CX20549 Venice doesn't work correctly. Status in “alsa-driver” package in Ubuntu: Incomplete Bug description: Computer: IBM Lenovo Thinkpad R61i Card: HDA Intel Sound chip: Conexant CX20549 (Venice) Device: 00:1b.0 Audio device [0403]: Intel Corporation 82801H (ICH8 Family) HD Audio Controller [8086:284b] (rev 03) Subsystem: Lenovo ThinkPad T61 [17aa:20ac] System: Ubuntu Oneiric 11.10 (desktop-i386) Kernel: 3.0.0-12-generic-pae#20-Ubuntu SMP Fri Oct 7 16:37:17 UTC 2011 Problems: 1) Integrated microphone doesn't work at all because the driver uses node 0x14 instead of 0x15 for integrated mic and node 0x12 instead of 0x14 for external mic. 2) Sound output is muted in the "0% <-> unamplified" part of the volume slider and is working in the "unamplified <-> 100% ->" part only; the driver doesn't allow amplified part because sound is distorted over 0dB of the PCM level so there is no need amplified part of the volume slider. Solution: Attached patch is fixing nodes of integrated and external microphone and is removing the amplified part of the volume slider. --- AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24. ApportVersion: 1.23-0ubuntu4 Architecture: i386 ArecordDevices: **** List of CAPTURE Hardware Devices **** card 0: Intel [HDA Intel], device 0: CONEXANT Analog [CONEXANT Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: c4pp4 1698 F.... pulseaudio /dev/snd/pcmC0D0p: c4pp4 1698 F...m pulseaudio CRDA: Error: [Errno 2] Adresář nebo soubor neexistuje Card0.Amixer.info: Card hw:0 'Intel'/'HDA Intel at 0xfe100000 irq 48' Mixer name : 'Conexant CX20549 (Venice)' Components : 'HDA:14f15045,17aa20db,00100100' Controls : 19 Simple ctrls : 10 Card29.Amixer.info: Card hw:29 'ThinkPadEC'/'ThinkPad Console Audio Control at EC reg 0x30, fw 7KHT24WW-1.08' Mixer name : 'ThinkPad EC 7KHT24WW-1.08' Components : '' Controls : 1 Simple ctrls : 1 Card29.Amixer.values: Simple mixer control 'Console',0 Capabilities: pswitch pswitch-joined penum Playback channels: Mono Mono: Playback [on] DistroRelease: Ubuntu 11.10 HibernationDevice: RESUME=UUID=6e091b39-d59a-4d75-a7c5-dec246d020e5 InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release i386 (20111012) MachineType: LENOVO 89329ZG Package: linux (not installed) PccardctlIdent: Socket 0: no product info available PccardctlStatus: Socket 0: no card ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.0.0-12-generic-pae root=UUID=666241df-0a9e-4711-a44e-92d2e6f5eccc ro quiet splash vt.handoff=7 ProcVersionSignature: Ubuntu 3.0.0-12.20-generic-pae 3.0.4 RelatedPackageVersions: linux-restricted-modules-3.0.0-12-generic-pae N/A linux-backports-modules-3.0.0-12-generic-pae N/A linux-firmware 1.60 Tags: oneiric Uname: Linux 3.0.0-12-generic-pae i686 UpgradeStatus: No upgrade log present (probably fresh install) UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare vboxusers dmi.bios.date: 04/09/2010 dmi.bios.vendor: LENOVO dmi.bios.version: 7OETC4WW (2.24 ) dmi.board.name: 89329ZG dmi.board.vendor: LENOVO dmi.board.version: Not Available dmi.chassis.asset.tag: No Asset Information dmi.chassis.type: 10 dmi.chassis.vendor: LENOVO dmi.chassis.version: Not Available dmi.modalias: dmi:bvnLENOVO:bvr7OETC4WW(2.24):bd04/09/2010:svnLENOVO:pn89329ZG:pvrThinkPadR61/R61i:rvnLENOVO:rn89329ZG:rvrNotAvailable:cvnLENOVO:ct10:cvrNotAvailable: dmi.product.name: 89329ZG dmi.product.version: ThinkPad R61/R61i dmi.sys.vendor: LENOVO To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/886975/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp