ok, I found the issue, the diff is buggy, extra lines got added to a new
file but the offset of the patch didn't get update which did lead to
have the end of file truncated... note for next time: don't try to be
too smart about reducing the diff for easier review

I've uploaded a 0ubuntu11 that fixes the bug

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-control-center in Ubuntu.
https://bugs.launchpad.net/bugs/1100587

Title:
  gnome-control-center does not remove system-wide proxy settings from
  /etc/environment when switch from manual to automatic mode.

Status in “gnome-control-center” package in Ubuntu:
  Invalid
Status in “gnome-control-center” source package in Precise:
  Fix Committed
Status in “gnome-control-center” source package in Quantal:
  Fix Committed

Bug description:
  * Impact: the environment proxy settings might end up being
  incorrectly set

  * Test Case:

  Go into system settings => network => Network Proxy => Method => Manual
  Set a proxy (I chose 'goats' for the http bit, and 8080 as the port.

  Click on 'apply system wide'.

  Note that /etc/environment contains 'http_proxy="http://goats:8080";'

  Then go into system settings => network => Network Proxy => Method => 
Automatic
  Set my automatic proxy config URL to my companies wpad.dat.
  Click on 'apply system wide'

  Note that /etc/environment still contains 'http_proxy="http://goats:8080";.
  This ends up hosing specific applications that read the proxy from the 
environment, instead of from wherever GNOME stores this data.

  * Regression potential: limited, check that the proxy settings are
  correctly set and used in both manual and automatic modes

  Ubuntu 12.04.1 LTS Precise

  gnome-control-center-1:3.4.2-0ubuntu0.8 (from precise-updates)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1100587/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to