Launchpad has imported 15 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=817356.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2012-12-02T02:47:58+00:00 Steve-c wrote: Bug 486918 added new image resizers from SKIA. Since this was enabled resized images on my ppc32 machine show up with a blue tint. The convolver code extracts the RGBA bits from each 32 bit pixel but doesn't take the endian order into account. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/0 ------------------------------------------------------------------------ On 2012-12-02T02:52:10+00:00 Steve-c wrote: Created attachment 687479 proposed fix. Detect that this is a PPC and set the BENDIAN then use that when extracting the bits Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/1 ------------------------------------------------------------------------ On 2012-12-03T15:50:36+00:00 Joe-drew wrote: Comment on attachment 687479 proposed fix. Detect that this is a PPC and set the BENDIAN then use that when extracting the bits Review of attachment 687479: ----------------------------------------------------------------- ::: gfx/2d/convolver.cpp @@ +206,3 @@ > if (has_alpha) > + accum[3] += cur_filter * source_data_rows[filter_y][byte_offset + > + A_OFFSET_IDX]; Can you just leave these all on the same line? @@ +231,5 @@ > // > // We only need to do this when generating the final output row (here). > + int max_color_channel = NS_MAX(out_row[byte_offset + R_OFFSET_IDX], > + NS_MAX(out_row[byte_offset + G_OFFSET_IDX], out_row[byte_offset > + + B_OFFSET_IDX])); Same line here too Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/2 ------------------------------------------------------------------------ On 2012-12-04T04:16:27+00:00 Steve-c wrote: Created attachment 688092 v2 of the patch, all one one line but this exceeds 80 characters Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/3 ------------------------------------------------------------------------ On 2012-12-04T04:32:56+00:00 Steve-c wrote: Created attachment 688094 v3 has the line break but in a better spot Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/4 ------------------------------------------------------------------------ On 2012-12-09T20:21:48+00:00 Landry-openbsd wrote: Pushed v3 in https://hg.mozilla.org/integration/mozilla- inbound/rev/69b924c155b0 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/5 ------------------------------------------------------------------------ On 2012-12-09T20:28:17+00:00 Matt-woodrow wrote: I would strongly recommend that the change to SkPreConfig.h gets a patch file added to gfx/skia/patches, or that this change be upstreamed to google's skia repo (or both!). Otherwise this change is at risk of being overwritten when we next update skia. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/6 ------------------------------------------------------------------------ On 2012-12-10T02:21:03+00:00 Steve-c wrote: submitted for review upstream https://codereview.appspot.com/6900063/ Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/7 ------------------------------------------------------------------------ On 2012-12-10T02:22:35+00:00 Steve-c wrote: Created attachment 690255 adds the changes to SkPreConfig.h as a patch listed in gfx/skia/patches This patch will add a patch file in gfx/skia/patches to alter SkPreConfig.h the next time we import upstream sources Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/8 ------------------------------------------------------------------------ On 2012-12-10T02:52:07+00:00 Joe-drew wrote: Sorry! I was confusing SkPreConfig.h with SkUserConfig.h, and incorrectly figured it didn't need to have a separate patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/9 ------------------------------------------------------------------------ On 2012-12-10T19:06:18+00:00 Ryanvm wrote: https://hg.mozilla.org/mozilla-central/rev/69b924c155b0 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/10 ------------------------------------------------------------------------ On 2013-03-09T16:23:53+00:00 Landry-openbsd wrote: Apparently attachment #690255 never went through review in m-c nor commited, and neither upstream who didnt reply on codereview. Should it be unbitrotten and r?'ed ? Stumbled upon this while investigating why skia got broken on ppc again (see #849253)... Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/32 ------------------------------------------------------------------------ On 2013-03-12T00:41:20+00:00 Ryanvm wrote: https://hg.mozilla.org/integration/mozilla-inbound/rev/049b349ac5a1 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/33 ------------------------------------------------------------------------ On 2013-03-12T19:55:28+00:00 Ryanvm wrote: https://hg.mozilla.org/mozilla-central/rev/049b349ac5a1 Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/34 ------------------------------------------------------------------------ On 2013-09-03T17:46:14+00:00 Oibaf wrote: *** Bug 844436 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1130857/comments/35 ** Changed in: firefox Status: Unknown => Fix Released ** Changed in: firefox Importance: Unknown => Medium -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1130857 Title: Some images have a blue tint Status in The Mozilla Firefox Browser: Fix Released Status in “firefox” package in Ubuntu: Fix Released Bug description: Firefox 19.0 on Xubuntu 12.10 on a Late 2005 Apple Mac mini. Steps to reproduce: 1. Open Firefox. 2. Navigate to an image-heavy website (Flickr, for instance). Note that some images have a blue tint. 3. If you already have enough of a browsing history, open a new tab and observe that the screenshots of your most visited pages also look too blue. Downgrading back to version 18.2 makes the problem go away, although using an outdated browser is not much of a workaround. I can test if required. ProblemType: Bug DistroRelease: Ubuntu 12.10 Package: firefox 18.0.2+build1-0ubuntu0.12.10.1 ProcVersionSignature: Ubuntu 3.5.0-24.37-powerpc-smp 3.5.7.4 Uname: Linux 3.5.0-24-powerpc-smp ppc AddonCompatCheckDisabled: False ApportVersion: 2.6.1-0ubuntu10 Architecture: powerpc AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: james 1451 F.... xfce4-volumed james 1471 F.... pulseaudio BuildID: 20130201191451 CRDA: Error: [Errno 2] No such file or directory: 'iw' Channel: Unavailable Date: Wed Feb 20 17:18:15 2013 ForcedLayersAccel: False IpRoute: default via 192.168.64.1 dev eth0 proto static 169.254.0.0/16 dev eth0 scope link metric 1000 192.168.64.0/24 dev eth0 proto kernel scope link src 192.168.64.8 metric 1 MarkForUpload: True Plugins: IcedTea-Web Plugin (using IcedTea-Web 1.3 (1.3-1ubuntu1.1)) - /usr/lib/jvm/java-7-openjdk-powerpc/jre/lib/ppc/IcedTeaPlugin.so (icedtea-7-plugin) PrefSources: prefs.js Profiles: Profile0 (Default) - LastVersion=18.0.2/20130201191451 (In use) RelatedPackageVersions: icedtea-7-plugin 1.3-1ubuntu1.1 RunningIncompatibleAddons: False SourcePackage: firefox UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1130857/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
