Hey Mattia,

there are a few nitpicks with this, and I figure as you are an aspiring
MOTU I'd rather tell you about them than just fixing them.

 * The package has a Vcs-Bzr:, thus merges should be done against that
branch. However, as it seems the desktop team pretty much lost interest
in this and the last few commits were just retroactively committed, I'm
actually in favor of reverting the Vcs-* change, leave Debian's git, and
drop our ubuntu specific Vcs branch.

 * The extra or changed Replaces: were only necessary for earlier
upgrades, that delta can be reverted now that trusty is out.

 * Since xscreensaver has not been installed on ubuntu/kubuntu/etc. for
a long time, and is only being used in Mythbuntu and Ubuntustudio, I
wonder whether the rather intrusive change for moving some screen savers
between packages is still necessary. Perhaps you can ping the leads of
these two derivatives to check whether we can drop this?

 * I suppose debian/xscreensaver.dirs isn't necessary, I'm fairly sure
that the "make install" bits will create directories by themselves.
(That needs to be double-checked of course)

Thanks!

** Changed in: xscreensaver (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xscreensaver in Ubuntu.
https://bugs.launchpad.net/bugs/1283459

Title:
  Please merge xscreensaver (5.26-1) from Debian unstable

Status in “xscreensaver” package in Ubuntu:
  Incomplete

Bug description:
  Changes since the last upload:

  xscreensaver (5.26-1) unstable; urgency=low

    * New upstream release 5.26, changes since 5.23:
      - Updated feed-loading for recent Flickr changes.
      - Updated `webcollage' for recent Google changes.
      - Added Instagram and Bing as `webcollage' image sources.
      - Updated to latest autoconf.
      - Bug fixes.
    * Drop patch applied upstream:
      - debian/patches/12_upstream_use_cppflags.patch
    * Bump Standards-Version to 3.9.5 (no changes needed)

   -- Tormod Volden <debian.tor...@gmail.com>  Mon, 17 Feb 2014 20:34:28
  +0100

  xscreensaver (5.23-1) unstable; urgency=low

    * New upstream release 5.23 (Closes: #729311)
      - New hack, geodesic
      - More heuristics for using RSS feeds as image sources
      - Improved Wikipedia parser
      - Updated webcollage for recent Flickr changes
      - Added Android to bsod
      - Made quasicrystal work on weak graphics cards
      - Better compression on icons, plists and XML files
      - Reverted that DEACTIVATE change. Bad idea.
      - Phosphor now supports amber as well as green
    * Dropped patches applied upstream:
      - 12_upstream_quasicrystal_texture_width.patch
      - 14_upstream_hexadrop_keyboard_exit.patch
      - 15_upstream_activate_faster_nontty.patch
    * debian/patches/12_upstream_use_cppflags.patch:
      Make sure CPPFLAGS are used (fixes hardening warnings)
    * debian/control: Update VCS fields (fixes Lintian warning)

   -- Tormod Volden <debian.tor...@gmail.com>  Sat, 23 Nov 2013 20:47:28
  +0100

  xscreensaver (5.22-1) unstable; urgency=low

    * New upstream release 5.22 (Closes: #699833), changes since 5.15:
      - XInput devices now also ignore small mouse motions
      - Loading images via RSS feeds is much improved
      - Enlarged the texture image for lament
      - Made pipes be ridiculously less efficient, but spin
      - Added better mouse control to rubik, cube21, crackberg, and julia
      - Cosmetic improvements to queens and endgame
      - sonar can now ping local subnet on DHCP
      - Most savers now resize/rotate properly
      - New version of `fireworkx'
      - Minor fixes to `distort', `fontglide', `xmatrix'
      - New MacOS crash in `bsod'
      - New mode in `lcdscrub'
      - Gnome/KDE instructions updated in man page (Closes: #640640)
      - New --enable-pam-check-account-type option (Closes: #656766)
      - Fixed imageDirectory URL parsing. Closes: #714582 (LP: #1116006)
      - Use of AC_SYS_LARGEFILE fixes inode number overflow when accessing
        image files on cifs file systems (LP: #609451) Thanks Mamoru Tasaka!
      - New hacks: kaleidocycle, quasicrystal, unknownpleasures, hexadrop
      - Performance improvements for `interference'.
      - Fixed possible crashes in apple2, maze, pacman, polyominoes,
        fireworkx, engine (LP: #1196251)
      - Fix for `bumps' in 64 bit.
      - Fixed "Shake to Randomize"; display name of saver.
      - Fixed rotation problems with `pacman', `decayscreen'.
      - Better dragging in `fluidballs'.
      - Ignore rotation in hacks that don't benefit from it.
      - Ignore DEACTIVATE messages when locked, instead of popping up the
        password dialog box.
      - Fix format string glitch in xscreensaver-text (LP: #781948)
        (thanks Emanuel Bronshtein)
    * debian/patches: Split up 53_XScreenSaver.ad.in.patch into
      logically separated and better named patches
    * debian/patches/57_grabDesktopImages_default_off.patch:
      Do not reveal desktop content by default (Closes: #679974)
    * debian/patches/12_upstream_quasicrystal_texture_width.patch:
      Adjust texture width to graphics card/driver capability
    * debian/patches/14_upstream_hexadrop_keyboard_exit.patch:
      Allow keyboard exit when run standalone (from upstream)
    * debian/patches/15_upstream_activate_faster_nontty.patch:
      Activate faster when not from tty session (LP: #1229486)
    * Bump Standards-Version to 3.9.4 (no changes needed)
    * debian/rules: Drop unnecessary dh_testroot from clean target
      (thanks Julien Cristau)
    * debian/rules: Include buildflags.mk for hardening options
    * Stop xscreensaver in prerm instead of postrm (Closes: 681613)
      (thanks Filipus Klutiero)
    * New xscreensaver daemon wrapper used by the example .desktop file
      to determine correct "New login" command.
    * debian/copyright: Updated to comply with accepted standard
    * debian/control: Make short descriptions more consistent
    * debian/control: Migrate Conflicts: to Breaks:

   -- Tormod Volden <debian.tor...@gmail.com>  Tue, 01 Oct 2013 22:00:48
  +0200

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xscreensaver/+bug/1283459/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to