First one looks good. Second one...not so sure. It made my custom-root- context-menuitem disappear (created with nautilus action)
-- You received this bug notification because you are a member of Desktop Packages, which is subscribed to nautilus in Ubuntu. https://bugs.launchpad.net/bugs/1577058 Title: SRU: Backport two fixes from upstream 3.14 into Xenial Status in nautilus package in Ubuntu: New Bug description: application-actions: use valid window list We were using the internal list of the application to iterate through the windows and closing them. Problem is that when closing one window, the list is modified, so next time accessing the list we are accessing the "old" list, which is invalid and makes nautilus crash. To fix it make a copy of the list to preserve the consistency. https://bugzilla.gnome.org/show_bug.cgi?id=755803 Fixing commit: https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-14&id=45413c18167cddaefefc092b63ec75d8fadc6f50 ------------------------------------------------------------ window-menus: unref extension created action This looks not very harmful. But definitely is. Thing is, when using nautilus_action_from_menu_item it keeps a reference to the NautilusMenuItem from the extension. So that menu item will never be freed. Now, let's imagine nautilus-open-terminal have a ref to the file that the item points to, and only unref it when the item is destroyed. Now, sum that when a file is not unrefed completely from nautilus when unmounting the file, so it's mark as gone and cannot be used again. Now try to use it in this state. Nautilus crashes. This fix few crashes reported downstream on distros that uses this extension. Fixing commit: https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-14&id=a0cbf72827b87a28fba47988957001a8b4fbddf5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1577058/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
