Martin: I can confirm that the giflib 5.1.4-0.3 packages in xenial-
proposed fix the reported problems.

Brian: How would those test cases look like?

Maybe this discussion is helpful:

https://github.com/jcupitt/libvips/issues/437

Running libvips master make test on 5.1.2-0.2 results in:

======================================================================
ERROR: test_gifload (test_foreign.TestForeign)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_foreign.py", line 483, in test_gifload
    self.file_loader("gifload", self.gif_file, gif_valid)
  File "test_foreign.py", line 68, in file_loader
    validate(self, im)
  File "test_foreign.py", line 477, in gif_valid
    a = im(10, 10)
  File "../python/packages/gi/overrides/Vips.py", line 846, in __call__
    return self.getpoint(x, y)
  File "../python/packages/gi/overrides/Vips.py", line 651, in call_function
    return _call_instance(self, name, args, kwargs)
  File "../python/packages/gi/overrides/Vips.py", line 426, in _call_instance
    return _call_base(name, args, kwargs, self)
  File "../python/packages/gi/overrides/Vips.py", line 376, in _call_base
    raise Error('Error calling operator %s.' % name)
Error: Error calling operator getpoint.
  gifload: Failed to read from given file
vips__region_start: start function failed for image images/cramps.gif


======================================================================
ERROR: test_magickload (test_foreign.TestForeign)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_foreign.py", line 331, in test_magickload
    self.file_loader("magickload", self.gif_file, gif_valid)
  File "test_foreign.py", line 70, in file_loader
    validate(self, im)
  File "test_foreign.py", line 321, in gif_valid
    self.assertAlmostEqual(a, [33, 33, 33, 255])
  File "/usr/lib/python2.7/unittest/case.py", line 554, in assertAlmostEqual
    if round(abs(second-first), places) == 0:
TypeError: unsupported operand type(s) for -: 'list' and 'list'

----------------------------------------------------------------------

FAILED (errors=2)
memory: high-water mark 127.03 MB
FAIL test_python.sh (exit status: 1)

============================================================================
Testsuite summary for vips 8.4.0
============================================================================
# TOTAL: 5
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See test/test-suite.log
Please report to vip...@jiscmail.ac.uk
============================================================================

Running libvips master make check on 5.1.4-0.3:

============================================================================
Testsuite summary for vips 8.4.0
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================



** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to giflib in Ubuntu.
https://bugs.launchpad.net/bugs/1580376

Title:
  Update giflib Xenial Package to 5.1.4

Status in One Hundred Papercuts:
  Confirmed
Status in giflib package in Ubuntu:
  Fix Released
Status in giflib source package in Xenial:
  Fix Committed

Bug description:
  Ubuntu Xenial Xerus currently ships with giflib 5.1.2-0.2, which is 
completely broken.
  It fails to read gif images in both libvips and imagemagick.

  Please update to 5.1.4-0.2, which is already published in Yakkety Yak.

  I have build the 5.1.4-0.2 package on Xenial and can confirm that it
  fixes both of the above mentioned problems.

  The upstream bug report is: https://sourceforge.net/p/giflib/bugs/94/

  And fix release is 5.1.4.

  Prepared 5.1.4, test built in the PPA ubuntu-toolchain-r/ppa, and
  test-build all rdeps in main (emacs24 libgdiplus libwebp openjdk-8
  tracker).

  Acceptance criteria:  Builds, and tests succeed on all architectures.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hundredpapercuts/+bug/1580376/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to