Launchpad has imported 18 comments from the remote bug at
https://bugzilla.redhat.com/show_bug.cgi?id=1332491.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2016-05-03T10:46:54+00:00 Matthias wrote:

Description of problem:
When connecting with NetworkManager-openconnect on Fedora 23 and before, the  
username and password could be saved. On Fedora 24 (Alpha-7) only the password 
is saved but the username field is empty, so the username has to be entered 
each time newly.

Version-Release number of selected component (if applicable):
 1.2.0-1.fc24

How reproducible:
Connect to a vpn twice

Steps to Reproduce:
1. enter vpn connection 
2. connect and check password save dialog
3. disconnect and connect again

Actual results:
username is not shown in dialog (only password bullets)
login failed is shown if connecting witout entering the username again.

Expected results:
username should be shown as well 

Additional info:

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/0

------------------------------------------------------------------------
On 2016-05-25T07:54:07+00:00 Robert wrote:

Seeing the same problem here on F24 Beta

$ rpm -qa|grep openconnect
openconnect-7.06-4.fc24.x86_64
NetworkManager-openconnect-1.2.2-1.fc24.x86_64

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/1

------------------------------------------------------------------------
On 2016-05-25T07:56:29+00:00 David wrote:

Going to blame NM itself for this. Will strip the stored username from
my own config (it was there before I upgraded) and attempt to
reproduce...

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/2

------------------------------------------------------------------------
On 2016-05-25T07:59:18+00:00 David wrote:

Note: NM-openconnect "makes up" secrets as it goes, to remember the
authentication form entries (the 'input' ones, not the 'password' ones
which end up being stored via libsecret.

So at the first *authentication*, because the server offers a form named
'main' which has a 'username' field, I end up with the auth-dialog
spitting out an extra secret that was never previously known, which (in
F23 and previously at least) resulted in:

# grep form: /etc/NetworkManager/system-connections/Intel\ AnyConnect\ VPN 
form:main:password-flags=1
form:main:username=david.woodho...@intel.com

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/3

------------------------------------------------------------------------
On 2016-06-23T12:09:09+00:00 Matthias wrote:

The problem still exists in final Fedora 24.

Is there a workaround?

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/4

------------------------------------------------------------------------
On 2016-07-03T11:13:26+00:00 Lubomir wrote:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=lr
/openconnect-secrets-rh1332491

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/5

------------------------------------------------------------------------
On 2016-07-04T14:39:54+00:00 Thomas wrote:

>> setting-vpn: get the flags property name only up to the first ":" in
secret

According to example from comment 3,

  form:main:password-flags=1
  form:main:username=david.woodho...@intel.com

it seems the secret name would be "form:main:username". Wouldn't the patch then 
lookup for "form-main-flags"? How does that fit with "form:main:password-flags"?
Surely the patch does it right, but the commit message does not explain the 
meaning of the ':'. It should show concrete examples of what openconnect does, 
and why we would truncate secret names at a colon.


It seems to me, that NMSettingVpn:get_secret_flags() should instead allow for a 
missing flags entry, but also consider whether there is an entry in the secrets.

Having a password in the @secrets hash, but no flags in @data, might
anyway be considered in inconsistent state. I think, NMSettingVpn should
treat "name" as secret if at least one of the following is true:

  - @secrets hash has an entry "name".
  - @data hash has an entry "name" + "-flags".

If the flags entry is missing, it should assume "0".


Above would make sense to me, regardless of any openconnect hacks. Wouldn't 
that fix the openconnect issue?

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/6

------------------------------------------------------------------------
On 2016-07-04T15:31:04+00:00 David wrote:

(In reply to Thomas Haller from comment #6)
> It seems to me, that NMSettingVpn:get_secret_flags() should instead allow
> for a missing flags entry, but also consider whether there is an entry in
> the secrets.

...

> Above would make sense to me, regardless of any openconnect hacks. Wouldn't
> that fix the openconnect issue?

As far as I was aware, that was how it always worked.

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/7

------------------------------------------------------------------------
On 2016-07-04T15:35:36+00:00 David wrote:

Ah, I had missed the fact that this was known to have been broken in
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1424f249e

An alternative suggestion... let us return *data* from the auth-dialog
to be stored for future connections, not just secrets. I can set the
flags explicitly then.

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/8

------------------------------------------------------------------------
On 2016-07-06T06:24:02+00:00 Joachim wrote:

(In reply to Robert de Rooy from comment #1)

Seeing the same problem here with the released F24 (Workstation)

openconnect-7.06-4.fc24.x86_64
NetworkManager-openconnect-1.2.2-1.fc24.x86_64
NetworkManager-1.2.2-2.fc24.x86_64

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/9

------------------------------------------------------------------------
On 2016-08-22T10:12:26+00:00 Lubomir wrote:

This is what was merged to essentially restore the old behavior:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=9b96bfaa722f3cccf0df3a3bca6e8f227643f94f

While extending the auth helper protocol certainly makes sense, it also
takes more work to do and a change in the VPN client as well. We could
do that in future, but for now this is probably sufficient.

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/14

------------------------------------------------------------------------
On 2016-08-22T10:13:17+00:00 Lubomir wrote:

Released in
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fade485364
(1.2.4-2.fc24)

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/15

------------------------------------------------------------------------
On 2016-09-04T13:57:01+00:00 Nurul wrote:

I faced the same problem on Fedora 24 Workstation

Name        : openconnect
Arch        : x86_64
Epoch       : 0
Version     : 7.07
Release     : 2.fc24

Name        : NetworkManager
Arch        : x86_64
Epoch       : 1
Version     : 1.2.4


Name        : NetworkManager-openconnect
Arch        : x86_64
Epoch       : 0
Version     : 1.2.2
Release     : 1.fc24

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/16

------------------------------------------------------------------------
On 2016-10-11T15:57:50+00:00 David wrote:

This still isn't working for me with NetworkManager-1.2.4-2.fc24

I provision a network with nmcli, and the 'save_passwords' secret is
never set even though the auth-dialog returns it.

If I manually add save_passwords-flags=0 to the vpn.data when
provisioning, it does get saved.

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/22

------------------------------------------------------------------------
On 2016-10-12T10:58:30+00:00 Thomas wrote:

9b96bfaa722f3cccf0df3a3bca6e8f227643f94f was never backported to nm-1-2
branch, and is thus not in any libnm-1.2.* up to now.

I cherry-picked the patch upstream:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=bb45adeda0bf427ada23b09daf970b0757e82d60

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/23

------------------------------------------------------------------------
On 2016-10-13T04:52:10+00:00 Fedora wrote:

NetworkManager-1.2.4-3.fc24 has been pushed to the Fedora 24 testing 
repository. If problems still persist, please make note of it in this bug 
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: 
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9317b4b65b

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/24

------------------------------------------------------------------------
On 2016-10-14T15:25:46+00:00 Matthias wrote:

Thanks a log David and Thomas, it works with NetworkManager-1.2.4-3.fc24
!

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/25

------------------------------------------------------------------------
On 2016-10-15T02:49:53+00:00 Fedora wrote:

NetworkManager-1.2.4-3.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this
bug report.

Reply at: https://bugs.launchpad.net/ubuntu/+source/network-manager-
openconnect/+bug/1609700/comments/26


** Changed in: fedora
       Status: Unknown => Fix Released

** Changed in: fedora
   Importance: Unknown => Low

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to network-manager in Ubuntu.
https://bugs.launchpad.net/bugs/1609700

Title:
  username is not saved in openconnect connection dialog

Status in network-manager package in Ubuntu:
  Confirmed
Status in network-manager-openconnect package in Ubuntu:
  Confirmed
Status in Fedora:
  Fix Released

Bug description:
  
  Hi,

  I clicked on "save passwords" but only the password is filled in
  automatically when I open the connection dialog. The "Username" field
  is empty!

  This happens for a SSLVPN configuration.

  For another VPN config (don't know which type) everything is ok.

  
  openconnect: 7.06-2build2

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1609700/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to