Comment on attachment 556542 gsettings proxy patch v 1 I looked at the GSettingsService changes.
There is a new symbol that needs to be added to the GSETTINGS_FUNCTIONS at the top of the file for dynamic lookup, and some other things to touch up there so that this compiles against old versions of GIO. >+#include "nsISupports.h" > #include "nsCOMPtr.h" >+#include "nsIMutableArray.h" I expect nsISupports.h does not need to be listed explicitly because nsIMutableArray.h or nsISupportsPrimitives.h will pull it in. >+ const gchar ** gs_strings = g_variant_get_strv(value, NULL); >+ g_variant_unref(value); gs_strings doesn't own the strings, only the list of pointers. What owns the strings after value is released? >+ if (!gs_strings) { >+ // empty array >+ return NS_OK; >+ } aResult needs to be set if returning NS_OK. >+ nsCOMPtr<nsIMutableArray> items(do_CreateInstance(NS_ARRAY_CONTRACTID)); >+ if (!items) >+ return NS_ERROR_OUT_OF_MEMORY; Leaks gs_strings. Probably tidiest to move this construction to before other allocations. >+ nsCOMPtr<nsISupportsString> obj(do_CreateInstance(NS_SUPPORTS_STRING_CONTRACTID)); Would it make sense to instead use nsISupportsCString? That would be more consistent with the AUTF8Strings returned by getString and used in parameters, and it is probably the format more useful to the caller in this case. Think about whether using NS_NewAdoptingUTF8StringEnumerator instead of nsIMutableArray would simplify things: http://hg.mozilla.org/mozilla-central/annotate/84117219ded0/xpcom/ds/nsStringEnumerator.h#l90 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/875266 Title: Firefox ignores GNOME 3 proxy settings Status in The Mozilla Firefox Browser: In Progress Status in “firefox” package in Ubuntu: Triaged Bug description: Firefox ignores GNOME3 proxy settings. This is regression from Natty+GNOME 2. How to reproduce: 1. set proxy in gnome-control-center 2. set 'Use system proxy settings' in Firefox settings (default) 3. open web pages Expected: 4. pages are shown using proxy Happened instead: 4. pages are not shown behind proxy WORKAROUND: use 'manual proxy configuration' in Firefox settings ProblemType: Bug DistroRelease: Ubuntu 11.10 Package: firefox 7.0.1+build1+nobinonly-0ubuntu2 ProcVersionSignature: Ubuntu 3.0.0-12.20-generic-pae 3.0.4 Uname: Linux 3.0.0-12-generic-pae i686 AddonCompatCheckDisabled: False AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24. AplayDevices: **** List of PLAYBACK Hardware Devices **** card 0: Intel [HDA Intel], device 0: ALC269 Analog [ALC269 Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 ApportVersion: 1.23-0ubuntu3 Architecture: i386 ArecordDevices: **** List of CAPTURE Hardware Devices **** card 0: Intel [HDA Intel], device 0: ALC269 Analog [ALC269 Analog] Subdevices: 1/1 Subdevice #0: subdevice #0 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC0: nobuto 1667 F.... pulseaudio BuildID: 20111008085056 CRDA: Error: [Errno 2] そのようなファイルやディレクトリはありません Card0.Amixer.info: Card hw:0 'Intel'/'HDA Intel at 0xf0a00000 irq 45' Mixer name : 'Realtek ALC269' Components : 'HDA:10ec0269,10cf0000,00100004 HDA:11c11040,10cf14a5,00100200' Controls : 17 Simple ctrls : 11 Channel: release CheckboxSubmission: 1d84ca1b2de43c2199974f7b8a6ca9cb CheckboxSystem: 0657dd966bc74d2b22e7c94051aa55af Date: Sun Oct 16 04:41:44 2011 EcryptfsInUse: Yes ForcedLayersAccel: False IfupdownConfig: auto lo iface lo inet loopback InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta i386 (20111007) IpRoute: default via 192.168.11.1 dev wlan0 proto static 169.254.0.0/16 dev wlan0 scope link metric 1000 192.168.11.0/24 dev wlan0 proto kernel scope link src 192.168.11.52 metric 2 Profiles: Profile0 (Default) - LastVersion=7.0.1/20111008085056 Profile1 - LastVersion=7.0.1/20111008085056 Profile2 - LastVersion=6.0.2/20110905174115 (Out of date) Profile3 - LastVersion=6.0/20110812234425 (Out of date) Profile4 - LastVersion=5.0/20110622232052 (Out of date) RunningIncompatibleAddons: False SourcePackage: firefox UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 03/30/2009 dmi.bios.vendor: FUJITSU // Phoenix Technologies Ltd. dmi.bios.version: Version 1.22 dmi.board.name: FJNB1E6 dmi.board.vendor: FUJITSU dmi.chassis.type: 10 dmi.chassis.vendor: FUJITSU dmi.modalias: dmi:bvnFUJITSU//PhoenixTechnologiesLtd.:bvrVersion1.22:bd03/30/2009:svnFUJITSU:pnFMVMGD75P:pvr:rvnFUJITSU:rnFJNB1E6:rvr:cvnFUJITSU:ct10:cvr: dmi.product.name: FMVMGD75P dmi.sys.vendor: FUJITSU To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/875266/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp