The cause of this bug is the unity-menubar.patch file, which Ubuntu and various other distros use to integrate firefox's menubar with Unity's, was updated but the context around that patch changed (ie Firefox changed) and the patch did not take that into account.
https://github.com/archlinuxcn/repo/blob/master/firefox-kde-opensuse /unity-menubar.patch#L5381 shows that the patch is trying to run the 'filter' method on `toolbarNodes`, but as of 59, `toolbarNodes` is no longer an array, it's just a list of child nodes, and so it has no `filter` method, and the call throws an exception. To get this fixed someone needs to update that patch to enforce that it's using an array. (sorry for the arch link, pretty sure Ubuntu is using the same debian patch, but I just spent 15 minutes trying to find a source link (online vcs rather than, say, a tarball which I obviously can't link into) that's used for ubuntu's package and can't, so...) ** Bug watch added: Mozilla Bugzilla #1428938 https://bugzilla.mozilla.org/show_bug.cgi?id=1428938 -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/1758107 Title: Firefox: View > Toolbars is Missing "Bookmarks Toolbar" Status in firefox package in Ubuntu: Confirmed Status in libdbusmenu package in Ubuntu: Confirmed Bug description: The "Bookmarks Toolbar" toggler is missing from the View > Toolbars menu in Firefox 59 on Ubuntu 16.04.4. Video: https://youtu.be/Josm0VqtUDQ ProblemType: Bug DistroRelease: Ubuntu 16.04 Package: firefox 59.0.1+build1-0ubuntu0.16.04.1 ProcVersionSignature: Ubuntu 4.13.0-37.42~16.04.1-generic 4.13.13 Uname: Linux 4.13.0-37-generic x86_64 AddonCompatCheckDisabled: False ApportVersion: 2.20.1-0ubuntu2.15 Architecture: amd64 AudioDevicesInUse: USER PID ACCESS COMMAND /dev/snd/controlC1: lonnie 1902 F.... pulseaudio /dev/snd/pcmC0D0p: lonnie 1902 F...m pulseaudio /dev/snd/controlC0: lonnie 1902 F.... pulseaudio BuildID: 20180316021607 Channel: Unavailable CurrentDesktop: Unity Date: Thu Mar 22 11:42:51 2018 ForcedLayersAccel: False IfupdownConfig: # interfaces(5) file used by ifup(8) and ifdown(8) auto lo iface lo inet loopback InstallationDate: Installed on 2018-02-09 (41 days ago) InstallationMedia: Ubuntu 16.04.3 LTS "Xenial Xerus" - Release amd64 (20170801) IpRoute: default via 192.168.77.1 dev enp3s0 proto static metric 100 169.254.0.0/16 dev enp3s0 scope link metric 1000 192.168.77.0/24 dev enp3s0 proto kernel scope link src 192.168.77.252 metric 100 NoProfiles: True RunningIncompatibleAddons: False SourcePackage: firefox UpgradeStatus: No upgrade log present (probably fresh install) dmi.bios.date: 05/31/2010 dmi.bios.vendor: Hewlett-Packard dmi.bios.version: F.25 dmi.board.asset.tag: Base Board Asset Tag dmi.board.name: 7001 dmi.board.vendor: Hewlett-Packard dmi.board.version: 35.35 dmi.chassis.type: 10 dmi.chassis.vendor: Hewlett-Packard dmi.chassis.version: N/A dmi.modalias: dmi:bvnHewlett-Packard:bvrF.25:bd05/31/2010:svnHewlett-Packard:pnHPPaviliondv8NotebookPC:pvr0499220000241210001040000:rvnHewlett-Packard:rn7001:rvr35.35:cvnHewlett-Packard:ct10:cvrN/A: dmi.product.family: 103C_5335KV dmi.product.name: HP Pavilion dv8 Notebook PC dmi.product.version: 0499220000241210001040000 dmi.sys.vendor: Hewlett-Packard To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1758107/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
