Updated the packages to the proposed versions. The fixes work for me.

Thank you, great job!

ii  gnome-flashback                                3.28.0-1ubuntu1.2            
amd64               
ii  metacity                                       1:3.28.0-1ubuntu0.1          
amd64                 

** Tags removed: verification-needed-bionic
** Tags added: verification-done-bionic

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to metacity in Ubuntu.
https://bugs.launchpad.net/bugs/1769838

Title:
  Per-window input sources option does not work on Bionic with gnome-
  flashback

Status in gnome-flashback package in Ubuntu:
  Fix Released
Status in metacity package in Ubuntu:
  Fix Released
Status in gnome-flashback source package in Bionic:
  Fix Committed
Status in metacity source package in Bionic:
  Fix Committed

Bug description:
  [Impact]

   * An explanation of the effects of the bug on users and:
     Setting the 'Input Source Options' to 'Allow different sources for each 
window' does not work.

   * justification for backporting the fix to the stable release:
     This is a bug in Ubuntu Bionic's version of gnome-flashback (3.28) 
(because the GUI lets the user change the input source option but the backend 
does nothing)

  [Test Case]

   * detailed instructions how to reproduce the bug
     - Set Input Source Options to Allow different sources for each window in 
gnome-control-center -> Region & Language -> Options
     - Realize that if you set different layouts for different windows it does 
not change automatically when changing windows.

  [Regression Potential]

  * Metacity now ignores its own events when predicting focus changes.
  Its own events are recognized by comparing timestamps and serial
  numbers. If something potentially goes wrong, it can either not ignore
  its own events, or ignore external events. In both cases the focus
  prediction will be broken. Also there could be potentially a race
  condition, but the patch protects against it by making a dummy request
  with bumped serial number. (Note: the second metacity patch is an
  amendment for the first one, so the previous analysis applies to both
  patches.)

  * GNOME-Flashback has some new code for handling per-window input
  sources. The change_per_window_source() function returns early if the
  sources_per_window option (obtained from GSettings: org.gnome.desktop
  .input-sources per-window) is false. As that option is false by
  default, in the default configuration most of the new code won't be
  executed at all. The potential breakage may happen if it is set to
  true. Such potential breakage includes: wrong input sources handling
  (it was wrong before anyway), gnome-flashback crashes. The patches are
  already applied in Cosmic, and currently no crashes are reported
  against the Cosmic version of gnome-flashback on errors.ubuntu.com.

  [Other Info]

  This needs fixes in both gnome-flashback and metacity.
  Here are the relevant commits in gnome-3-28 branches:

  https://gitlab.gnome.org/GNOME/metacity/commit/b96341dabffc3589 (ensure that 
we ignore our own focus events for focus predictions)
  https://gitlab.gnome.org/GNOME/metacity/commit/9956d376d38d0ad6 (fix problems 
with focus tracking)
  https://gitlab.gnome.org/GNOME/gnome-flashback/commit/3c4c6ecddef48cd5 
(implement per window input sources)

  The gnome-session-flashback dependency on metacity will be bumped.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-flashback/+bug/1769838/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to