Comment on attachment 594363 Don't disable warn-on-quit when session restore is enabled
Review of attachment 594363: ----------------------------------------------------------------- Sorry for the delay. I've had this on my mind for a while though. My main problem here is that this doesn't really do what the end goal of this bug is. This simply removes a check from the dialog path, but it doesn't handle the keyboard case at all, which is what we really want. So I think we should move discussion about this specifically to a new bug. Since this is (mostly) only going to affect people who manually gone & changed showQuitWarning to true & have sessionstore on, it shouldn't be too disruptive. Though, we'll show the quit dialog which asks about saving tabs when session restore is already on... so that's not ok. Also, all the people quitting by closing the last window will suddenly have a dialog in their face, event without showQuitWarning (I think I take back "shouldn't be too disruptive"). We can discuss more in a new bug if you file it -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: Invalid Bug description: Binary package hint: firefox 1) lsb_release -rd Description: Ubuntu 11.10 Release: 11.10 2) apt-cache policy firefox firefox: Installed: 11.0+build1-0ubuntu0.11.10.1 Candidate: 11.0+build1-0ubuntu0.11.10.1 Version table: *** 11.0+build1-0ubuntu0.11.10.1 0 500 http://us.archive.ubuntu.com/ubuntu/ oneiric-updates/main i386 Packages 500 http://security.ubuntu.com/ubuntu/ oneiric-security/main i386 Packages 100 /var/lib/dpkg/status 7.0.1+build1+nobinonly-0ubuntu2 0 500 http://us.archive.ubuntu.com/ubuntu/ oneiric/main i386 Packages 3) What is expected to happen in Firefox, with Edit -> Preferences -> Tabs -> "Warn on closing with multiple tabs open" checkbox checked, is when one click the X, File -> Quit, Ctrl+Q , or Alt+Space -> C, one get's the confirmation box: Confirm close You are about to close x tabs. Are you sure you want to continue? 4) What happens instead is one is not warned and the window closes. PARTIAL WORKAROUND: about:config -> browser.tabs.maxOpenBeforeWarn -> change from 15 to 2. This will pop up the confirmation box clicking the X and Alt+Space -> C only. WORKAROUND: Disable Ctrl+Q quiting the browser by installing keyconfig add-on: http://mozilla.dorando.at/keyconfig.xpi Then Tools -> Add-Ons -> Extensions -> keyconfig Preferences -> highlight Quit -> Disable Original Reporter Comments: I found a "workaround" that says to set "open to a blank page" somewhere else, and I set this, but it still doesn't warn me. I work from home and frequently spend an hour or so putting in data, all on one screen. If I accidentally hit the stupid little x (which is now in the left hand corner just where you don't need it, it is too easy to hit it by accident, but i can't change this, it comes with the distro), i lose all that work. Please tell me how to fix this terrible bug. Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3 GTB7.1 THIS BUG AFFECTS MY SECURITY (INCOME) but i guess would not be classifed as a security bug per se ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Fri May 21 14:07:40 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429) ProcEnviron: LANG=en_GB.UTF-8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp