(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #48) > (In reply to Meridel from comment #46) > > Prefs copy looks good and hasn't changed from what we have currently. > > > > Edits to close warning dialogue: > > -Numbers less than ten should be spelled out. So if the user is closing 2 - > > 9 tabs, spell out the number of tabs. > > This is really annoying to implement, and requires localizers to provide > translations for all these numbers. It also makes it harder to scan for the > numbers when reading the warning. It's also not clear to me that any > convention in (American?) English that you're using here applies in other > languages (eg I grew up in the Netherlands and the rule I got taught was to > write out numbers under 20, as well as any numbers divisible by 10 (under > 100) or 100 (under 1000), etc.). So it would be "five thousand tabs" but > "5341 tabs". I would be unsurprised if other languages used other > conventions still. It also doesn't seem related to this bug. If you feel > strongly that this is necessary, can you file a separate bug for this, maybe > with more details about how that should work? > > For the changes to the prefs: > > (In reply to Amy Lee [:amylee] UX from comment #44) > > I've attached a spec for Preferences when Session Restore is Enabled and > > Disabled. The warning will not show up by default if Session Restore is > > enabled but I've added a pref that allows users to turn the warning message > > on when Session Restore is enabled if desired. > > I have a several concerns here. > > First, now if users have session restore enabled there is 1 pref that > governs both window closing and quitting. Unfortunately, there isn't a pref > to turn on warnings for quit but not have warnings when closing multiple > tabs otherwise. This would be desirable because it's easy to mis-hit cmd-q > when trying to hit cmd-w (to close a tab). You have to try pretty hard to > mis-hit cmd-shift-w (to close a window) or to close multiple tabs using the > mouse. So I want a warning when quitting but not when closing a window, but > I can't have that either today or with the implementation you're suggesting. > That seems like something we should fix.
I think we are getting very specific for an issue that I think affects a small population of users. It starts to become overkill if we try to provide such specific checkbox options (ie. warn me when quitting, warn me when closing a window, etc.). > > Second, users who are used to the current behavior with session restore > enabled (esp. on Windows, where mis-hitting ctrl-shift-q is also not a major > concern) will start getting warning dialogs when we implement the new > behavior. That seems disruptive. But we can't turn off the warning > everywhere because then they won't get a warning when closing a window, > which they might have relied upon. Any thoughts about how to address that? The default settings of Session Restore would be what we have currently (not having warnings). The user can turn on the warning when closing multiple tabs in Prefs. If they accidentally close a window, it's less of a destructive action because Session Restore is enabled so if that does accidentally happen, their tabs are restored anyways when they reopen. Again, I believe this affects a small population of users. If they are that worried about accidental closing, they are given the option to turn the warnings back on. -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to firefox in Ubuntu. https://bugs.launchpad.net/bugs/583797 Title: "Warn on closing with multiple tabs open" not honored Status in Mozilla Firefox: Fix Released Status in firefox package in Ubuntu: Invalid Bug description: Binary package hint: firefox 1) lsb_release -rd Description: Ubuntu 11.10 Release: 11.10 2) apt-cache policy firefox firefox: Installed: 11.0+build1-0ubuntu0.11.10.1 Candidate: 11.0+build1-0ubuntu0.11.10.1 Version table: *** 11.0+build1-0ubuntu0.11.10.1 0 500 http://us.archive.ubuntu.com/ubuntu/ oneiric-updates/main i386 Packages 500 http://security.ubuntu.com/ubuntu/ oneiric-security/main i386 Packages 100 /var/lib/dpkg/status 7.0.1+build1+nobinonly-0ubuntu2 0 500 http://us.archive.ubuntu.com/ubuntu/ oneiric/main i386 Packages 3) What is expected to happen in Firefox, with Edit -> Preferences -> Tabs -> "Warn on closing with multiple tabs open" checkbox checked, is when one click the X, File -> Quit, Ctrl+Q , or Alt+Space -> C, one get's the confirmation box: Confirm close You are about to close x tabs. Are you sure you want to continue? 4) What happens instead is one is not warned and the window closes. PARTIAL WORKAROUND: about:config -> browser.tabs.maxOpenBeforeWarn -> change from 15 to 2. This will pop up the confirmation box clicking the X and Alt+Space -> C only. WORKAROUND: Disable Ctrl+Q quiting the browser by installing keyconfig add-on: http://mozilla.dorando.at/keyconfig.xpi Then Tools -> Add-Ons -> Extensions -> keyconfig Preferences -> highlight Quit -> Disable Original Reporter Comments: I found a "workaround" that says to set "open to a blank page" somewhere else, and I set this, but it still doesn't warn me. I work from home and frequently spend an hour or so putting in data, all on one screen. If I accidentally hit the stupid little x (which is now in the left hand corner just where you don't need it, it is too easy to hit it by accident, but i can't change this, it comes with the distro), i lose all that work. Please tell me how to fix this terrible bug. Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3 GTB7.1 THIS BUG AFFECTS MY SECURITY (INCOME) but i guess would not be classifed as a security bug per se ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: firefox 3.6.3+nobinonly-0ubuntu4 ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-22-generic i686 Architecture: i386 Date: Fri May 21 14:07:40 2010 FirefoxPackages: firefox 3.6.3+nobinonly-0ubuntu4 firefox-gnome-support 3.6.3+nobinonly-0ubuntu4 firefox-branding 3.6.3+nobinonly-0ubuntu4 abroswer N/A abrowser-branding N/A InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429) ProcEnviron: LANG=en_GB.UTF-8 SHELL=/bin/bash SourcePackage: firefox To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/583797/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
