I believe this is due to a simplistic handling of "freeness" in
UbuntuDrivers.detect._is_package_free() – any package not from
restricted or multiverse is considered free:

    # it would be better to check the actual license, as we do not have
    # the component for third-party packages; but this is the best we can do
    # at the moment
    if pkg.candidate.section.startswith('restricted') or \
            pkg.candidate.section.startswith('multiverse'):
        return False
    return True

Possibly it would be better to do the logic the other way around ("if
it's in main/universe/whatever, then it's free, otherwise it's
nonfree"), but really a better solution is needed.

However, I notice that the Nvidia drivers on my system are from section
"non-free/libs" – the following patch fixes the problem for me:

--- a/UbuntuDrivers/detect.py   2019-01-10 02:30:54.326668673 +0000
+++ b/UbuntuDrivers/detect.py   2019-01-10 02:36:24.707733516 +0000
@@ -165,7 +165,8 @@
     # the component for third-party packages; but this is the best we can do
     # at the moment
     if pkg.candidate.section.startswith('restricted') or \
-            pkg.candidate.section.startswith('multiverse'):
+            pkg.candidate.section.startswith('multiverse') or \
+            pkg.candidate.section.startswith('non-free'):
         return False
     return True

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to ubuntu-drivers-common in Ubuntu.
https://bugs.launchpad.net/bugs/1514057

Title:
  Incorrect(?) reporting of freeness of third-party nVidia drivers from
  graphic-drivers PPA

Status in ubuntu-drivers-common package in Ubuntu:
  Confirmed

Bug description:
  pumpkin@pumpkin:~/4788.5236.la$ sudo ubuntu-drivers devices
  == /sys/devices/pci0000:00/0000:00:03.0/0000:03:00.0 ==
  modalias : pci:v000010DEd00001080sv000010B0sd00000401bc03sc00i00
  model    : GF110 [GeForce GTX 580]
  vendor   : NVIDIA Corporation
  driver   : nvidia-340-updates - distro non-free
  driver   : nvidia-352-updates - distro non-free
  driver   : nvidia-355 - third-party free recommended
  driver   : nvidia-352 - third-party free
  driver   : xserver-xorg-video-nouveau - distro free builtin
  driver   : nvidia-340 - distro non-free
  driver   : nvidia-304-updates - distro non-free
  driver   : nvidia-304 - distro non-free

  I have some difficulty believing that nvidia-352 is free and
  nvidia-352-updates non-free; I would have thought nvidia-352 and
  nvidia-355 are both third-party non-free.

  it is possible this is the result of having some extra PPAs installed:

  pumpkin@pumpkin:~/4788.5236.la$ sudo apt-get install nvidia-355
  Reading package lists... Done
  Building dependency tree       
  Reading state information... Done
  Recommended packages:
    libcuda1-355 nvidia-opencl-icd-355
  The following packages will be upgraded:
    nvidia-355
  1 to upgrade, 0 to newly install, 0 to remove and 19 not to upgrade.
  Need to get 58.6 MB of archives.
  After this operation, 3,072 B of additional disk space will be used.
  Get:1 http://ppa.launchpad.net/graphics-drivers/ppa/ubuntu/ wily/main 
nvidia-355 amd64 355.11-0ubuntu0~gpu15.10.2 [58.6 MB]

  So maybe this is a matter of package status being marked up
  incorrectly in the PPA?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-drivers-common/+bug/1514057/+subscriptions

-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to