The verification of the Stable Release Update for gnome-shell-extension- desktop-icons has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.
-- You received this bug notification because you are a member of Desktop Packages, which is subscribed to gnome-shell-extension-desktop-icons in Ubuntu. https://bugs.launchpad.net/bugs/1880031 Title: Thumbnail is stretched if its aspect ratio is less than that of the container Status in gnome-shell-extension-desktop-icons: Unknown Status in gnome-shell-extension-desktop-icons package in Ubuntu: Fix Released Status in gnome-shell-extension-desktop-icons source package in Focal: Fix Released Bug description: [ Impact ] Image thumbnails are stretched if the aspect ratio is less than the one of the container [ Test case ] To reproduce, create an image that has aspect ratio, e.g., ~0.5 (e.g. width = 250 and height = 500) Save it in the desktop and ensure that the image has proper proportions. [ Regression potential ] Image thumbnails are distorted ---- This was discovered when investigating fix for bug #1868529. Aspect ratio is still not correct for images that are more narrow than the container. To reproduce, create an image that has aspect ratio, e.g., ~0.5 (e.g. width = 250 and height = 500). Line in fileItem.js where we calculate icon width does not count the margins (zero is used instead of actual margins): let containerWidth = Prefs.getDesiredWidth(scaleFactor, 0); Here is how the margins are being calculated in desktopGrid.js: this._extra_width = themeNode.get_margin(St.Side.LEFT) + themeNode.get_margin(St.Side.RIGHT) + themeNode.get_border_width(St.Side.LEFT) + themeNode.get_border_width(St.Side.RIGHT) + themeNode.get_horizontal_padding(); this._extra_height = themeNode.get_margin(St.Side.TOP) + themeNode.get_margin(St.Side.BOTTOM) + themeNode.get_border_width(St.Side.TOP) + themeNode.get_border_width(St.Side.BOTTOM) + themeNode.get_vertical_padding(); To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1880031/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
