This looks good, but in addition to the test case in the description, please add a couple of things to your test plan for SRU verification:
1) Dirk F's steps to reproduce in comment 2, because that's the real user impact for which we're doing this SRU. 2) I agree with your assessment under "Regression Potential", so in mitigation please also exercise some other cases of ghostscript command line parsing - for example without '--' - that other tools might use, to ensure that we aren't regressing them. ** Description changed: [Impact] - * The command line syntax `gs [options] -- <input_file>` fails - to load in the input file with a "permission denied" error. - * Per the ghostscript documentation, the `--` syntax is used as follows: - "-- filename arg1 ... - Takes the next argument as a file name as usual, - but takes all remaining arguments (even if they - have the syntactic form of switches) and defines - the name ARGUMENTS in userdict (not systemdict) - as an array of those strings, before running the - file. When Ghostscript finishes executing the file, - it exits back to the shell." + * The command line syntax `gs [options] -- <input_file>` fails + to load in the input file with a "permission denied" error. + * Per the ghostscript documentation, the `--` syntax is used as follows: + "-- filename arg1 ... + Takes the next argument as a file name as usual, + but takes all remaining arguments (even if they + have the syntactic form of switches) and defines + the name ARGUMENTS in userdict (not systemdict) + as an array of those strings, before running the + file. When Ghostscript finishes executing the file, + it exits back to the shell." - [Test Case] + [Test Plan] ---------- to be performed in a desktop environment ---------- - * Obtain a valid input file for ghostscript. The Source package - contains an `examples/` directory with plenty to choose from. - * `gs -- <input-file>` - * Observe that the test failed with a "permission denied" error. - * Install the version of ghostscript from focal-proposed. - * `gs -- <input-file>` - * Observe that the command succeeds and a ghostscript window. - appears with the output of the `gs` command. + * Obtain a valid input file for ghostscript. The Source package + contains an `examples/` directory with plenty to choose from. + * `gs -- <input-file>` + * Observe that the test failed with a "permission denied" error. + * Install the version of ghostscript from focal-proposed. + * `gs -- <input-file>` + * Observe that the command succeeds and a ghostscript window. + appears with the output of the `gs` command. + + In addition see comment 6 and comment 2 for two more items in the test + plan. -- ~racb [Regression Potential] - * Since this patch affects command line processing, it is possible - that other arguments or command line syntaxes could be affected. + * Since this patch affects command line processing, it is possible + that other arguments or command line syntaxes could be affected. [Original Description] Ghostscript 9.50 exhibits https://bugs.ghostscript.com/show_bug.cgi?id=701894 (fix the '--' and co options) which causes (eg) ocrfeeder to fail to load PDF files: an input file specified using the "... -- filename ..." command line syntax has no read permission in the GS interpreter. This commit fixes it: http://git.ghostscript.com/?p=ghostpdl.git;a=commit;h=24ec06a27df63297796a379c95ee5d4b39040410 GS 9.52 includes the commit. Either apply the fix from the linked commit in the Focal-Updates version, or upgrade it to 9.52. ** Changed in: ghostscript (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to ghostscript in Ubuntu. https://bugs.launchpad.net/bugs/1913656 Title: `gs [options] -- <input_file>` fails with "permission denied" Status in ghostscript package in Ubuntu: Fix Released Status in ghostscript source package in Focal: Fix Committed Bug description: [Impact] * The command line syntax `gs [options] -- <input_file>` fails to load in the input file with a "permission denied" error. * Per the ghostscript documentation, the `--` syntax is used as follows: "-- filename arg1 ... Takes the next argument as a file name as usual, but takes all remaining arguments (even if they have the syntactic form of switches) and defines the name ARGUMENTS in userdict (not systemdict) as an array of those strings, before running the file. When Ghostscript finishes executing the file, it exits back to the shell." [Test Plan] ---------- to be performed in a desktop environment ---------- * Obtain a valid input file for ghostscript. The Source package contains an `examples/` directory with plenty to choose from. * `gs -- <input-file>` * Observe that the test failed with a "permission denied" error. * Install the version of ghostscript from focal-proposed. * `gs -- <input-file>` * Observe that the command succeeds and a ghostscript window. appears with the output of the `gs` command. In addition see comment 6 and comment 2 for two more items in the test plan. -- ~racb [Regression Potential] * Since this patch affects command line processing, it is possible that other arguments or command line syntaxes could be affected. [Original Description] Ghostscript 9.50 exhibits https://bugs.ghostscript.com/show_bug.cgi?id=701894 (fix the '--' and co options) which causes (eg) ocrfeeder to fail to load PDF files: an input file specified using the "... -- filename ..." command line syntax has no read permission in the GS interpreter. This commit fixes it: http://git.ghostscript.com/?p=ghostpdl.git;a=commit;h=24ec06a27df63297796a379c95ee5d4b39040410 GS 9.52 includes the commit. Either apply the fix from the linked commit in the Focal-Updates version, or upgrade it to 9.52. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ghostscript/+bug/1913656/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
