@Dirk, are you sure you attached the right changeset? The patch is adding autopkgtest to the package. Also such changes should be submitted against the upstream project for review on https://github.com/tseliot/ubuntu-drivers-common/pulls
-- You received this bug notification because you are a member of Desktop Packages, which is subscribed to ubuntu-drivers-common in Ubuntu. https://bugs.launchpad.net/bugs/1990341 Title: [SRU] Support to install nvidia driver by allowing list Status in OEM Priority Project: Confirmed Status in ubuntu-drivers-common package in Ubuntu: Incomplete Bug description: [ Impact ] * In NVIDIA new GPU release cycle, NVIDIA ships their new GPUs to OEM/ODM for production. In the meantime, NVIDIA usually notify OEM/ODM/Canonical (under NDA) to use a specific nvidia version to development/production. NVIDIA and OEN/ODM will announce the next generation combination at the same time usually when the factory ready to ship the product. We made Ubuntu as a leading distribution supports many cutting edge devices, it's time to have an official way to make the nvidia installation consistent in unannounced (yet) nvidia devices to support OEM/ODM factory shipment for our growing counterparts. [ Test Plan ] * For this feature which only impact if the target system has a custom file "/etc/custom_supported_gpus.json" If the file presents, it will effect packages_for_modalias() and _is_runtimepm_supported(). Both functions are important when "ubuntu- driver install" a nvidia driver. For installing nvidia driver, u-d-c has several test in autopkgtest which contains: * different branch type: LTS/PB/NFB/Legacy.. * different version type: 390/470/495/510/520/525.. * For this particular feature, we created a new autopkgtest test_system_driver_packages_force_install_nvidia() which not only secure this FFE but each version bump. which contains: 1. Normal case (Stock ubuntu), without /etc/custom_supported_gpus.json in the system. 2. If /etc/custom_supported_gpus.json contains incorrect json field / format. 3. /etc/custom_supported_gpus.json point to the older version than candidate. 4. /etc/custom_supported_gpus.json point to the same version than candidate. 5. /etc/custom_supported_gpus.json point to a non-exist version of ubuntu-archive (source list). and you can see from "buildlog" attachment, all passed as well as "test_system_driver_packages_force_install_nvidia()" Refer https://github.com/tseliot/ubuntu-drivers-common/pull/71 for more details. * Steps to make sure it works: 1. pick a cutting edge nvidia graphic. 2. remove nv-525 from the pool. 3. add ppa, apt update and reboot. 4. check the nv support status: ``` $ ubuntu-drivers list oem-fix-gfx-nvidia-ondemandmode libfprint-2-tod1-broadcom oem-somerville-cinccino-meta ``` 5. modify custom file ``` $ cat /etc/custom_supported_gpus.json { "chips": [ { "devid": "0x24BA", "name": "TEST 24BA", "branch": "580.1234", "features": [ "runtimepm" ] }, { "devid": "0x25BC", "name": "TEST 25BC", "branch": "510", "features": [ "runtimepm" ] } ] } ``` 6. make sure the hook works ``` $ ubuntu-drivers list nvidia-driver-510, (kernel modules provided by nvidia-dkms-510) oem-fix-gfx-nvidia-ondemandmode libfprint-2-tod1-broadcom oem-somerville-cinccino-meta [ Where problems could occur ] * Think about what the upload changes in the software. Imagine the change is wrong or breaks something else: how would this show up? * It is assumed that any SRU candidate patch is well-tested before upload and has a low overall risk of regression, but it's important to make the effort to think about what ''could'' happen in the event of a regression. * This must '''never''' be "None" or "Low", or entirely an argument as to why your upload is low risk. * This both shows the SRU team that the risks have been considered, and provides guidance to testers in regression-testing the SRU. [ Other Info ] * Upstream commit: https://github.com/tseliot/ubuntu-drivers-common/commit/a7d2d39805e995ed0e655de123b4bb6cff4e6434 * Jammy MP: https://github.com/tseliot/ubuntu-drivers-common/pull/81 * Test PPA: https://launchpad.net/~os369510/+archive/ubuntu/lp1990341 * build log (as file) Please refer the attachment "buildlog" * install log Please refer the attachment "installlog" To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1990341/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
