Hi, I have some comments/questions. ## debdiffs
- The d/changelog entries target unstable and not Ubuntu releases - The lunar version string is wrong, the suffix should be ubuntu0.1. - The d/changelog entry is not clear. For example: it begins with "This service". Which service? - Nit: when adding new patches it is nice to mention it in d/changelog: * d/p/intel-mutual-authentication.patch: upstream cherry-pick to enable the XYZ feature ## dep-3 headers "Origin": please specify if "upstream" or "backport", see [1]. It may be "upstream" for some Ubuntu releases and "backport" for others, if the patch had to be modified to apply cleanly. Also: normally the link is to the individual cherry-picked commit, not to the PR/MR. "Applied-Upstream": not needed in this case I believe. AIUI that's for when the patch originates from Ubuntu/Debian and then has been applied upstream. In this case it's the other way around. "Reviewed-by": that's specific to the Ubuntu patch, do not put upstream contributions there: they are not involved with the Ubuntu packaging. ## general questions It is not clear to me (and may not be clear to the SRU team) what the actual impact of this issue. Is the hardware unusable without this feature? In other words: please improve the [Impact] section. Which issue will users encounter because of this bug? (What does it mean that the device is "secured" until unlocked?) Like Christian mentioned, it would be better to wait for 1.30 to be tagged by upstream before going ahead with the backporting. Would the libmbim release schedule align with the hardware release dates? [1] https://dep-team.pages.debian.net/deps/dep3/ -- You received this bug notification because you are a member of Desktop Packages, which is subscribed to libmbim in Ubuntu. https://bugs.launchpad.net/bugs/2014954 Title: Backport Intel Mutual Authentications - FCC Lock Status in OEM Priority Project: Confirmed Status in libmbim package in Ubuntu: In Progress Status in libmbim source package in Jammy: New Status in libmbim source package in Lunar: New Bug description: [ Impact ] There exist no formal API to do the FCC unlock procedure[1] in the latest version of the modemmanger. But there is a merged commit[2] that provide this functionality for intel WWAN cards in the upstream project. Lenovo have several laptops using the Intel WWAN cards, and Lenovo are struggling to give a decent way to run the FCC unlock service without this. [ Test Plan ] OEM enablement engineers and Lenovo engineers will help to test if the FCC unlock would work on certain laptops with the help of a custom package[1] provided by Lenovo which contains the FCC unlock script. [ Where problems could occur ] This is a completely new feature to support Intel WWAN cards mutal authentication, which does not affect other existing features. But the feature itself might have bugs and glitches since it is a brand new one and is not widely tested by the laptop vendors, still it is better than nothing. [ Other Info ] [1] FCC unlock procedure: https://modemmanager.org/docs/modemmanager/fcc-unlock/ [2] intel-mutual-authentication: new service, fcc-lock: https://gitlab.freedesktop.org/mobile-broadband/libmbim/-/merge_requests/157 - when the device is first shipped or comes out of the factory, it should be protected with a lock till the device reaches the end user. This FCC lock feature will ensure the device is secured till its unlocked. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2014954/+subscriptions -- Mailing list: https://launchpad.net/~desktop-packages Post to : desktop-packages@lists.launchpad.net Unsubscribe : https://launchpad.net/~desktop-packages More help : https://help.launchpad.net/ListHelp
