Hi Jürgen, thank you for the explanations. Should I file a issue for the PDF thing?
Greetings, Tobias Juergen Schmidt schrieb: > Hi Tobias, > > the whole extension mechanism evolved over the time. I agree that the > API should fail for files that can't be installed in general like a PDF. > The other things are not so easy to decide. A missing description.xml is > still a valid extension package. The description.xml was introduced > later. You remember we started with plain zip files. One can argue that > an oxt file must have a description.xml (and of course it should) but we > decided to be flexible here. That means we check the content and see > what we can install. A missing Addons.xcu doesn't mean that the oxt file > is invalid. xcu files are required for some extensions but not > necessarily for all kind of extensions. > > When i remember it correctly an oxt file is visible but disabled when > one part referenced in the manifest is corrupt or can't be installed. I > think this is fine. For some files you get an error box giving more > details. But that is not always possible. > A missing description.xml results in a question mark because the info > from the description.xml are not available but the content is ok. > > It's not easy to decide. Especially if we won't break older extensions. > But i agree that we should try to improve the error handling if > possible. I don't know the detailed behavior of the API without testing > it myself again but i think it's not easy possible at the moment. > > Juergen > > > > Tobias Krais wrote: >> Hi together, >> >> I deploy my OXT via Java API. And I created some unit tests. One is for >> checking failure behaviour: e.g. I try to install a PDF or other non-OXT >> and it works! Is this correct behaviour? >> Checking if the PDF file is installed returns false. But the Extension >> Manager Dialogue shows the PDF file with a questionmark. >> >> A similar behaviour is when I install broken OXTs (broken means that >> files like the description.xml or Addons.xcu is missing). Depending on >> which OXT content files are missing, the extension is correctly >> installed or is just shown with a questionmark. >> >> Souldn't the installation fail if the OXT isn't correct or is even a PDF >> file? >> >> Greetings, >> >> Tobias >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@api.openoffice.org >> For additional commands, e-mail: dev-h...@api.openoffice.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@api.openoffice.org > For additional commands, e-mail: dev-h...@api.openoffice.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@api.openoffice.org For additional commands, e-mail: dev-h...@api.openoffice.org
