dghgit commented on issue #455: URL: https://github.com/apache/mina-sshd/issues/455#issuecomment-1899331731
It was AES based. The BC LTS release supports AES pipelining on the Intel architecture which is why paying attention to what is coming back from update is so important (I mean, it was already important, but here it's **really** important). Yes, there should be a call to Cipher.doFinal() somewhere (on this one we couldn't find one either, but then we didn't spend a lot of time looking, it probably needs someone more familiar with the code). BaseCipher, in terms of update, is clearly wrong by inspection. From the point of view of how Java providers work, it is almost a miracle it ever worked, even with BC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
