[
https://issues.apache.org/jira/browse/PDFBOX-5834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852472#comment-17852472
]
Michael Klink commented on PDFBOX-5834:
---------------------------------------
Your patch looks very focused on a specific use case - copying invisible named
pages while explicitly dropping visible ones. Why that?
Also you copy page-like objects (the invisible templates) between documents by
simply adding them. If you look at {{Splitter.processPage}}, though, you'll see
that regular pages are copied in a much different way.
I'd propose reconsidering the intention (why only copy invisible named pages)
and making sure the eventual implementation handles the named pages with as
much care as the remaining {{Splitter}} does.
> [PATCH] PDF split missing names from documentCatalog
> ----------------------------------------------------
>
> Key: PDFBOX-5834
> URL: https://issues.apache.org/jira/browse/PDFBOX-5834
> Project: PDFBox
> Issue Type: Bug
> Reporter: Simon Steiner
> Priority: Major
> Attachments: tmp.patch
>
>
> java -jar app/target/pdfbox-app-2.0.32-SNAPSHOT.jar PDFSplit xxx.pdf
> I would expect to see the names dict inside the documentCatalog which is used
> to store pdf templates
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
