Dieter von Holten created PDFBOX-5862:
-----------------------------------------

             Summary: is o.a.p.cos.COSArray supposed to contain nulls?
                 Key: PDFBOX-5862
                 URL: https://issues.apache.org/jira/browse/PDFBOX-5862
             Project: PDFBox
          Issue Type: Improvement
          Components: Documentation
    Affects Versions: 3.0.2 PDFBox
            Reporter: Dieter von Holten


inspection by spotbugs shows a warning at line 573, which references a null 
from the list and compares it with the given value. When the list contains a 
null, and a null is passed by the caller, this is considered a match and the 
index is returned to the caller.

However, other locations in COSArray cannot deal with null entries in the list.

i propose:

1.) update the document to state whether null is a valid list-entry

2.) consider the use of COSNull when the caller tries to insert null. in this 
case, the users (those who get() values out) of COSArray need to be aware of 
the change

 

 

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Reply via email to