----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73421/#review226950 -----------------------------------------------------------
src/org/apache/pig/impl/builtin/StreamingUDF.java Line 471 (original) <https://reviews.apache.org/r/73421/#comment315226> Why remove this? By accident? src/python/streaming/controller.py Lines 73 (patched) <https://reviews.apache.org/r/73421/#comment315233> Python 3 also seems to have the binary mode for fdopen. Why remove it? src/python/streaming/controller.py Line 119 (original), 137 (patched) <https://reviews.apache.org/r/73421/#comment315227> nitpick. formatting needs to have space after , for arguments. Few other places as well. src/python/streaming/controller.py Lines 335-336 (original), 359-361 (patched) <https://reviews.apache.org/r/73421/#comment315231> This part is wrong. Has map code copied into bag. src/python/streaming/controller.py Lines 361 (patched) <https://reviews.apache.org/r/73421/#comment315230> WRAPPED_MAP_END -> WRAPPED_BAG_END test/e2e/pig/tests/nightly.conf Line 4192 (original), 4193 (patched) <https://reviews.apache.org/r/73421/#comment315232> What is the reason for the ROUND_TO change ? test/e2e/pig/tools/test/floatpostprocessor.pl Line 45 (original), 45 (patched) <https://reviews.apache.org/r/73421/#comment315228> Only whitespace change. Can revert. - Rohini Palaniswamy On Sept. 25, 2024, 7:50 p.m., Venkatasubrahmanian Narayanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73421/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2024, 7:50 p.m.) > > > Review request for pig. > > > Repository: pig-git > > > Description > ------- > > Support Python 3 for streaming_python > > > Diffs > ----- > > src/org/apache/pig/impl/builtin/StreamingUDF.java e1ce0da43 > src/python/streaming/controller.py 74b4e022d > test/e2e/pig/tests/nightly.conf f09d8c9fb > test/e2e/pig/tools/test/floatpostprocessor.pl 704484244 > test/e2e/pig/udfs/cpython/scriptingudf.py 3796aba0a > > > Diff: https://reviews.apache.org/r/73421/diff/1/ > > > Testing > ------- > > The Python Streaming UDF tests pass without errors. > > > Thanks, > > Venkatasubrahmanian Narayanan > >
