snoopdave commented on code in PR #160:
URL: https://github.com/apache/roller/pull/160#discussion_r4179026403
##########
app/src/main/webapp/themes/alpenglow/day.vm:
##########
@@ -0,0 +1,28 @@
+#foreach($entry in $entries)
+<article class="story">
+ <div class="story-index" aria-hidden="true">$velocityCount</div>
Review Comment:
Velocity 2 removed `$velocityCount`, and Roller's `velocity.properties`
doesn't enable the old name, so this prints the literal text `$velocityCount`
on every entry. Rendered with Velocity 2.4: `#foreach($x in
$l)$velocityCount#end` gives `$velocityCount$velocityCount`. Use
`$foreach.count` (as `gaurav` and `frontpage` use `$foreach.index`).
##########
app/src/main/webapp/themes/alpenglow/footer.vm:
##########
@@ -0,0 +1,10 @@
+<footer class="site-footer">
+ <p>
+ <strong>$model.weblog.name</strong>
+ — #if($model.weblog.tagline)$model.weblog.tagline#elseField notes from a
life in motion.#end
Review Comment:
Velocity reads `#elseField` as one unknown directive, not `#else` + text.
With a tagline this prints `My tagline#elseField notes from a life in motion.`;
without one, the fallback never shows. Use `#{else}Field notes from a life in
motion.` (Horizon's footer works because it has a space after `#else`).
##########
app/src/main/webapp/themes/dispatch/day.vm:
##########
@@ -0,0 +1,30 @@
+#foreach($entry in $entries)
+<article class="dispatch">
+ <div class="dispatch-number">#if($velocityCount<10)0#end$velocityCount</div>
Review Comment:
Velocity 2 removed `$velocityCount`, and Roller's `velocity.properties`
doesn't enable the old name, so this prints the literal text `$velocityCount`
on every entry. Rendered with Velocity 2.4: `#foreach($x in
$l)$velocityCount#end` gives `$velocityCount$velocityCount`. Use
`$foreach.count` (as `gaurav` and `frontpage` use `$foreach.index`).
Here: `#if($foreach.count<10)0#end$foreach.count`.
##########
app/src/main/webapp/themes/alpenglow/tags.vm:
##########
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ #includeTemplate($model.weblog "standard_head")
+ <title>$model.tags — $model.weblog.name</title>
+ </head>
+ <body>
+ #includeTemplate($model.weblog "standard_header")
+ <main id="content" class="reading-shell">
+ <header class="page-title">
+ <p class="kicker">Stories filed under</p>
+ <h1>$model.tags</h1>
Review Comment:
`$model.tags` is a `List<String>`, so this renders with list brackets, e.g.
`[java]` or `[java, roller]`. Same on line 5 (`<title>`). Suggest joining the
tags with a `#foreach`.
##########
app/src/main/webapp/themes/horizon/tags.vm:
##########
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ #includeTemplate($model.weblog "standard_head")
+ <title>$model.tags — $model.weblog.name</title>
+ </head>
+ <body>
+ #includeTemplate($model.weblog "standard_header")
+ <main id="content" class="article-shell">
+ <header class="page-heading">
+ <p class="eyebrow">Topic</p>
+ <h1>$model.tags</h1>
Review Comment:
`$model.tags` is a `List<String>`, so this renders with list brackets, e.g.
`[java]` or `[java, roller]`. Same on line 5 (`<title>`). Suggest joining the
tags with a `#foreach`.
##########
app/src/main/webapp/themes/dispatch/tags.vm:
##########
@@ -0,0 +1,19 @@
+<!doctype html>
+<html lang="en">
+ <head>
+ #includeTemplate($model.weblog "standard_head")
+ <title>$model.tags / $model.weblog.name</title>
+ </head>
+ <body>
+ #includeTemplate($model.weblog "standard_header")
+ <main id="content" class="reading-shell">
+ <header class="page-title">
+ <p class="label">FILTER / TAG</p>
+ <h1>$model.tags</h1>
Review Comment:
`$model.tags` is a `List<String>`, so this renders with list brackets, e.g.
`[java]` or `[java, roller]`. Same on line 5 (`<title>`). Suggest joining the
tags with a `#foreach`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
