On 6/25/14, 1:25 PM, Kim Gräsman wrote:
On Tue, Jun 24, 2014 at 10:30 PM, Gregory Szorc <[email protected]> wrote:
- Can I ask questions on this list? Send patches for review?
I vote for converting the repo to Git and throwing it up at
github.com/mozilla/pymake.
That would work much better for me, I'm still less familiar with hg.
- How careful do I need to be with library structure stability? Do you
have a lot of Python code using pymake as a library or is the make.py
driver the primary entry point? I'd like to start with setuptools
packaging for pymake, and that would require some cleaning up of
imports (e.g. ``import pymake.data`` instead of ``import data``.)
We have a few tools that talk to the internals, but nothing major. Unless
you are doing crazy refactoring (which I doubt you'll want to due to the
complexities of pymake), I don't think rebasing will be much trouble. As
long as you don't change the version of pymake in Firefox's repo, I don't
think anyone at Mozilla will care.
I'll try not to go crazy, but the import names will likely change to
be fully qualified, both internally and externally.
- If I can get packaging set up, I'd like to have pymake published to
pypi. Unfortunately, there's already a pymake on there
(https://pypi.python.org/pypi/pymake/0.9) but it looks abandoned, so I
could figure something out with the author.
+1
Cool. Chris McDonough graciously deleted his obsolete PyPI package, so
the name is on the market again.
pymake has its own test suite that is independent of Firefox.
Yeah, I found them in the pymake tree, thanks! How do I run them
correctly, though? Pymake hangs on the first one on my Windows setup:
$ python runtests.py
Test: gmake: pymake:
Running ['gmake'] with options ['-C', '_mktests', '-f',
'D:\\dev\\pymake\\tests\\automatic-variables.mk', 'TESTPATH=D:/d
ev/pymake/tests', 'NATIVE_TESTPATH=D:\\dev\\pymake\\tests', '__WIN32__=1']
Running ['C:\\Python27\\python.exe', 'D:\\dev\\pymake\\make.py'] with
options ['-C', '_mktests', '-f', 'D:\\dev\\pymake\
\tests\\automatic-variables.mk', 'TESTPATH=D:/dev/pymake/tests',
'NATIVE_TESTPATH=D:\\dev\\pymake\\tests', '__WIN32__=1'
]
# hangs here...
All I've done is to put Python 2.7 in the path, and add a MinGW make
executable as gmake also in the path.
There is code in pymake that does shell detection and adjusts run-time
behavior accordingly. It's quite possible the test harness doesn't work
outside of msys.
Did you try running the tests inside the msys environment shipped with
MozillaBuild?
_______________________________________________
dev-builds mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-builds
