On Thursday, October 27, 2016 at 4:41:30 PM UTC-7, Nathan Froyd wrote: > On Thu, Oct 27, 2016 at 7:31 PM, Chris Peterson <[email protected]> wrote: > > The Stylo team would like to make libclang a build-time dependency so we can > > generate C++/Rust bindings as part of the local build. > > What is the benefit of doing this, especially for people not working on Stylo?
For stylo, we generate Rust representations for all sorts of C++ data structures. If those memory layouts are wrong, it's a memory hazard. If we don't generate the bindings at build time, we would need to check them into the tree, which means that developers would need to manually run the binding generator any time they changed a bound data structure (including all sorts of stuff in xpcom, MFBT, dom, and layout). Forgetting to do this would be sec-critical, and people will most certainly forget. And even if they didn't, it would be a huge PITA. bholley _______________________________________________ dev-builds mailing list [email protected] https://lists.mozilla.org/listinfo/dev-builds
