On Tue, May 30, 2023 at 10:20:33AM -0700, John Baldwin wrote: > On 5/30/23 1:19 AM, Dmitry Chagin wrote: > > The branch main has been updated by dchagin: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=4f2c2a122c6fc1e129f93767234ae8107fcf5d0d > > > > commit 4f2c2a122c6fc1e129f93767234ae8107fcf5d0d > > Author: Dmitry Chagin <[email protected]> > > AuthorDate: 2023-05-30 08:19:40 +0000 > > Commit: Dmitry Chagin <[email protected]> > > CommitDate: 2023-05-30 08:19:40 +0000 > > > > avx_sig: Adapt avx_sig test for Aarch64 > > Reviewed by: kib > > Differential Revision: https://reviews.freebsd.org/D40309 > > The comment at the top of avx_sig.c still references AVX and %xmm FWIW and > needs updating. (The fact that it is also only testing xmm makes it an SSE > test on x86 and not an AVX test anyway) > > Can we also rename this tool now as avx_sig isn't a very intuitive name for > an aarch64 test? Maybe call it simd_sig given your earlier changes? >
yes, it's not finished, I want to add avx and then rename/correct everything > I'm also not quite sure what the 'c2x2c' part of the filename means for the > MD files? The functions it defines are 'cpu_to_simd' and 'simd_to_cpu', so > maybe just 'simd_<arch>.S' makes more sense? (And you could also perhaps > use MACHINE_CPUARCH in SRCS to require fewer .if's in the Makefile) > indeed, thanks > -- > John Baldwin
