It remains the case, for me at least, that KASSERT is not defined where it is used in math64.h, and so compilation still fails.

On 8/18/23 00:14, Kyle Evans wrote:
On 8/18/23 00:09, Kyle Evans wrote:
On 8/17/23 20:21, Bjoern A. Zeeb wrote:
The branch main has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=b80ea452375f52a3ab7d82a9aef10da0d89985d9

commit b80ea452375f52a3ab7d82a9aef10da0d89985d9
Author:     Bjoern A. Zeeb <[email protected]>
AuthorDate: 2023-05-16 20:55:00 +0000
Commit:     Bjoern A. Zeeb <[email protected]>
CommitDate: 2023-08-18 01:20:39 +0000

     LinuxKPI: implement mul_u64_u64_div_u64()
     Implement mul_u64_u64_div_u64() for an updated iwlwifi driver (though
     we do not yet use it there; it is used for in-kernel ptp on wifi).
     Sponsored by:   The FreeBSD Foundation
     Submitted by:   cperciva
     MFC after:      10 days
     Reviewed by:    cperciva, dwmalone
     Differential Revision: https://reviews.freebsd.org/D40120

This broke buildkernel on multiple architectures, it seems: https://ci.freebsd.org/tinderbox/

I've confirmed that reverting this commit fixes it. I'd be lying if I claimed to understand what's going on:

I lied; I looked again at the context and realized it was just missing an extra closing parentheses. I went ahead and hammered it away in dabbbebcb0f5...

Thanks,

Kyle Evans


Reply via email to