On Wed, Nov 18, 2015 at 1:47 AM, Aus Lacroix <[email protected]> wrote:
> Jonas, that particular error is on the decline. Many went away when we > rolled out a series of a fixes to run the tests on devices. The error > itself was a symptom of a different issue. I would imagine that the ones > that we still see occurring are, likely, also not directly related to > sockit-to-me. > FWIW, in working on bug 1222215 I haven't seen the dreaded "Cannot call send of undefined" error once. I didn't want to jinx it, but I think we can safely say this is no longer an issue for us (knock on wood). > > Even though this is the case, we recognize that synchronous tcp socket > usage isn't ideal (we didn't think it was in the first place, necessarily, > it was just the best way to make the tests easy to write). > > FFWD to now, we're adding a promise based tcp driver for marionette which > will enable new tests to be written using promises. Marionette calls would > always return a promise which you could .then() to do something else. It's > a much nicer, and standardized pattern. > Putting in my two cents, I love the fact that sockit-to-me is synchronous. It allows me to read, write, and understand tests very quickly. I realize there are performance problems with a busy wait, but I don't think this is a problem during marionette tests since they aren't user facing. What other advantages does switching to a Promise based driver give us? Do we think the tests will be less intermittent?
_______________________________________________ dev-fxos mailing list [email protected] https://lists.mozilla.org/listinfo/dev-fxos
