[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregory Joseph updated MAGNOLIA-2517:
-------------------------------------
Description:
While working on MAGNOLIA-2245, previewMode is being moved from
info.magnolia.cms.util.Resource to AggregationState.
Given the InterceptFilter is setting this flag, and uses the session to do so,
it seems we could use a cleaner implementation.
Using the session is somehow still needed, for instance to serve resources /
images appropriately.
One of the things that bother me with the current implementation is that gui
components access the aggregation state freely (global state) - this c/should
instead be passed to the output methods.
was:
While working on MAGNOLIA-2245, previewMode is being moved from
info.magnolia.cms.util.Resource to AggregationState.
Given the InterceptFilter is setting this flag, and uses the session to do so,
it seems we could use a cleaner implementation.
Using the session is somehow still needed, for instance to serve resources /
images appropriately.
> Cleaner refactoring for previewMode
> -----------------------------------
>
> Key: MAGNOLIA-2517
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2517
> Project: Magnolia
> Issue Type: Improvement
> Components: admininterface, core, gui
> Reporter: Gregory Joseph
> Assignee: Gregory Joseph
> Fix For: 4.0
>
>
> While working on MAGNOLIA-2245, previewMode is being moved from
> info.magnolia.cms.util.Resource to AggregationState.
> Given the InterceptFilter is setting this flag, and uses the session to do
> so, it seems we could use a cleaner implementation.
> Using the session is somehow still needed, for instance to serve resources /
> images appropriately.
> One of the things that bother me with the current implementation is that gui
> components access the aggregation state freely (global state) - this c/should
> instead be passed to the output methods.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------
