[
http://jira.magnolia-cms.com/browse/MAGNOLIA-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26035#action_26035
]
Grégory Joseph commented on MAGNOLIA-2969:
------------------------------------------
Patch applied - minor style corrections. I also removed the support for
importing any type (and the corresponding that checked URLs could be imported),
since they are not supported jcr property types. Let me know if I'm missing
something.
Now, one thing I want to do before applying MAGNOLIA-2970 and letting this go
in the wild, is revise the API. The API previous to this patch was already a
half-baked thing; it should either be all static, or not. (import methods were
non-static, exports were static).
I'd also like to see if we can remove/simplify the duplication of code wrt type
conversions (I don't think all the {{convert*ToExportString}} methods are
necessary)
But thanks, great stuff anyhow ! :)
> Enhance magnolia propertiesImportExporter to handle Dates, and to export to a
> properties file
> ---------------------------------------------------------------------------------------------
>
> Key: MAGNOLIA-2969
> URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-2969
> Project: Magnolia
> Issue Type: Improvement
> Components: core
> Affects Versions: 4.2.1
> Reporter: Ryan Gardner
> Assignee: Grégory Joseph
> Fix For: 4.3
>
> Attachments: enhancePropertyExporting2.patch,
> propertiesExporting3.patch
>
>
> In my opinion, one of the biggest hassles in creating a unit test for
> something that is driven by data in a repository is creating the properties
> file to drive the test.
> There was a mostly-implemented properties exporter in core but it didn't
> support writing out the data in the same format that it reads it in (namely,
> it didn't write the @uuid information or the @type information that it
> supports when importing from a properties file)
> This patch enhances the importer / exporter to the point where you can dump
> out content to a Properties or to a string representation of the properties.
> In addition, the Date nodes weren't dumped properly before. I added in some
> basic support for dumping and retrieving the Calendar objects from the
> properties file.
> I think that this, combined with another patch I'm about to submit that adds
> a "dump to properties format" to the JCR Queries page in Admin Interface
> should greatly reduce the pain for creating unit tests that operate using
> data from a repository.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------
