[ http://jira.magnolia-cms.com/browse/MGNLDATA-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=26626#action_26626 ]
Hudson CI server commented on MGNLDATA-70: ------------------------------------------ Integrated in !http://hudson.magnolia-cms.com/nocacheImages/16x16/blue.gif! [magnolia-module-data #487|http://hudson.magnolia-cms.com/job/magnolia-module-data/487/] MGNLDATA-70 set default post save js command only when it was not overridden by the user and can be constructed properly. > DataDialog limits should not hardcode the return value of > getJsExecutedAfterSaving > ---------------------------------------------------------------------------------- > > Key: MGNLDATA-70 > URL: http://jira.magnolia-cms.com/browse/MGNLDATA-70 > Project: Magnolia Data Module > Issue Type: Bug > Affects Versions: 1.3.2 > Reporter: Will Scheidegger > Assignee: Jan Haderka > Fix For: 1.4.1 > > Attachments: DataDialog.getJsExecutedAfterSaving.patch > > > DataDialog.getJsExecutedAfterSaving() returns a hardcoded String: > "opener.mgnl.data.DataTree.reloadAfterEdit('" + this.itemType + "', '" + > this.path + "')". This will get the opener to load the standard tree for the > node type at the given path. But if the dialog was called from somewhere else > (e.g. custom tree) then the user is out of luck. Therefore there should be a > way to simply reload/refresh the opener page in the state it was before. > The patch below changes the behavior of DataDialog.getJsExecutedAfterSaving() > so that it only returns the JS to load the standard tree when nothing else > has been specified. This seems to work for the standard data trees and for > custom trees. However I have not tested this for other situations (e.g. > opening the dialog from a custom page). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia-cms.com/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com> ----------------------------------------------------------------