Error page not rendered anymore after an exception on a template
----------------------------------------------------------------

                 Key: MAGNOLIA-3174
                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3174
             Project: Magnolia
          Issue Type: Bug
    Affects Versions: 4.3.1
            Reporter: Fabrizio Giustina
            Assignee: Fabrizio Giustina
            Priority: Critical


Not sure what has changed, but looks like that after 4.3-m3 response pages in 
case of errors during the template rendering have been broken.

Same page, same error: in previous versions the error page is properly served, 
in 4.3 final/4.3.1 we only get a blank page with a "response already committed" 
in tomcat logs.

The flush of the response is done in 
info.magnolia.module.templating.renderers.AbstractTemplateRenderer.renderTemplate()
 in a finally block.
Looks like the flush() was already there but somehow it was not breaking error 
pages.... after the introduction of the RenderingEngine I have to remove the 
flush() for making error pages work again.


Should we move the out.flush() outside the finally block to fix it? Is anybody 
aware of the reason why it should be there?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------

Reply via email to