[
http://jira.magnolia-cms.com/browse/MGNLFORUM-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27823#action_27823
]
Grégory Joseph commented on MGNLFORUM-62:
-----------------------------------------
comments on the patch:
* do not delete the thread when attempting to delete the first message. (do
nothing or throw an exception instead)
* since the deleteThread method already has similar mechanisms, reuse/refactor
them
* use the constants for the property names
* i'm not sure sorting by jcr:date is the best approach, rather than simply
taking the last sibling (might not be good for nested messages) - same goes for
the current deleteThread implementation. {{SiblingsHelper}} might help.
* see my comment above - we need to fix the "lastMessage" of the forum node too.
> Make it possible to erase the last message of a thread
> ------------------------------------------------------
>
> Key: MGNLFORUM-62
> URL: http://jira.magnolia-cms.com/browse/MGNLFORUM-62
> Project: Magnolia Forum Module
> Issue Type: Improvement
> Reporter: Grégory Joseph
> Assignee: Grégory Joseph
> Fix For: 1.3
>
> Attachments: mgnlforum-62.patch
>
>
> As of now, it cannot be removed because it is still being referenced. It
> should be feasible to update the lastMessage property of a thread by using
> the javax.jcr.Node.getSiblings() method to retrieve the previous message ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
