[ 
http://jira.magnolia-cms.com/browse/MAGNOLIA-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=29095#action_29095
 ] 

Bert Leunis commented on MAGNOLIA-3252:
---------------------------------------

I'll add some extra info that was exchanged on the user list.


Bert said: The versionhandlers should recognize the move from 1.3.1-SNAPSHOT to 
1.3.1 as an upgrade. Is that correct?

Jan answered: 
The answer is "it depends". When you work with the snapshots you are using a 
module that is in an undeterminate state. It might be in early phase of the 
version development and there are not update tasks yet or it might be in the 
very late stage and all the update tasks are already in place. In the first 
case you want to run the update tasks when moving to final version, in the 
second you don't. There is no signature for each task so it is not possible to 
determine whether given task was executed or not. Decision is in this case up 
to you as a maintainer of the system.
If you don't want to have any tasks executed, leave everything as is and just 
replace snapshot jar with the final one. If on the other hand you want to 
execute the update tasks, change the version number of given module to the 
previous version and after the restart update tasks will be executed.

Bert replied: I see. But apart from that, shouldn't at least the version number 
be updated?
It looks very strange to have a jar with version 4.3.2 on the classpath, but a 
version number in the configuration of 4.3.2-SNAPSHOT.

Jan replied: Yeah, it should be.

> Version should not ignore SNAPSHOT classifier
> ---------------------------------------------
>
>                 Key: MAGNOLIA-3252
>                 URL: http://jira.magnolia-cms.com/browse/MAGNOLIA-3252
>             Project: Magnolia
>          Issue Type: Bug
>          Components: updatemechanism
>    Affects Versions: 4.3.2
>            Reporter: Nils Breunese
>            Assignee: Boris Kraft
>            Priority: Minor
>
> We have used some Magnolia and STK/ETK SNAPSHOT jars for a while on our 
> central development repository and upgraded to final releases when they 
> became available. The version numbers in the configuration workspace still 
> say "4.3.2-SNAPSHOT" and "1.3.1-SNAPSHOT" though.
> Javadoc for info.magnolia.module.model.Version says: "Format is 
> x.y.z-classifier. y,z and classifier are optional. The classifier string is 
> ignored in version comparisons." I feel this could result in problems if 
> version handler are changed during the SNAPSHOT phase. We install the 
> SNAPSHOT jar, the module version is set to a SNAPSHOT version in the 
> configuration workspace, but when we later upgrade to the release jar the 
> Version class doesn't think the release version number is more recent, so the 
> version handler won't be executed again.
> I feel it would be good to modify the Version class to reflect that version 
> "x.y.z" is more recent than "x.y.z-SNAPSHOT".

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------

Reply via email to