ThemeInstallTask will never update a mobile theme configuration, missing
boostratp task
---------------------------------------------------------------------------------------
Key: MGNLSTK-973
URL: http://jira.magnolia-cms.com/browse/MGNLSTK-973
Project: Magnolia Standard Templating Kit
Issue Type: Bug
Components: themepop
Affects Versions: 2.0.3, 2.0.2, 2.0.1, 2.0
Reporter: Christian Ringele
Priority: Critical
Fix For: 2.0.x
The concept of the ThemeVersionHandler is to reinstall the whole theme on any
update of the module.
But the ThemeInstallTask just bootstraps the base theme configuration, but not
a mobile theme.
This didn't show up, because on module installation both configurations are
bootstrapped by the BaseInstallTasks of the DefaultModuleVersionHandler
(basicInstallTasks.add(new ModuleBootstrapTask());).
But on update, only the 'base' theme (the one defined in the themes module
descriptor) is re-bootstrapped:
{code}
new BootstrapSingleResource("", "", "/mgnl-bootstrap/theme-" + themeName +
"/config.modules.standard-templating-kit.config.themes." + themeName + ".xml",
ImportUUIDBehavior.IMPORT_UUID_COLLISION_REPLACE_EXISTING).execute(ctx);
{code}
Solution:
I think most proper solution would be defining two properties within the module
descriptor, one for the base theme, and one for the mobile theme.
{code}
<properties>
<property>
<name>themeName</name>
<value>pop</value>
</property>
<property>
<name>mobileThemeName</name>
<value>pop-mobile</value>
</property>
</properties>
{code}
Using an custom task which checks if the property 'mobileThemeName' is defined,
and if so bootstraps it.
(For the case you're not using a mobile theme)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia-cms.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: <dev-list-unsubscr...@magnolia-cms.com>
----------------------------------------------------------------
